The default bug view has changed. See this FAQ.

codegenerator should be able generate implementations which inherit other simple events

RESOLVED FIXED

Status

()

Core
DOM: Events
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Patch coming
Created attachment 652566 [details] [diff] [review]
patch

this simplifies CC handling so that all the generated classes have the
CC related macros and forward calls to parent, eventually nsDOMEvent which is
anyway cycle collectable.
Attachment #652566 - Flags: review?(khuey)
Created attachment 652570 [details]
example .cpp

This is an example .cpp when I added nsIDOMClose2Event which inherited
nsIDOMCloseEvent, and nsIDOMClose3Event which inherited nsIDOMClose2Event.

(2 and 3 added foobar2 and foobar3 properties, and to test CC stuff, I added
also target2 and target3)
https://tbpl.mozilla.org/?tree=Try&rev=3b7edd610419
Ted, with this patch the patch you wrote earlier today isn't needed to fix CCable member variable issue you got.
If you just want to dupe bug 783234 to this, that's fine. I haven't landed it yet.
Depends on when khuey might have time to review this. Or you can review this too ;)
Blocks: 604039
Blocks: 783856
Attachment #652566 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/36e366621f46
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 783234
You need to log in before you can comment on or make changes to this bug.