Closed Bug 783390 Opened 11 years ago Closed 11 years ago

Switch to new drag and drop api in history

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.15 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.15
Tracking Flags:
Tracking Status
seamonkey2.15 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Use dragstart [Checked in: Comment 4]
4.48 KB, patch
neil
: review+
Details | Diff | Splinter Review
Attached patch Switch history (obsolete) — — Splinter Review 
We're still using the old drag and drop API in history, so this patch fixes that
Attachment #652580 - Flags: review?(neil)
Comment on attachment 652580 [details] [diff] [review]
Switch history

>       <handler event="draggesture"><![CDATA[
Shouldn't we switch to dragstart while we're here?

>       <handler event="dragover"><![CDATA[
Do we actually need this event if we don't want to drop anything?
Use dragstart instead of draggesture and remove dragover.
Attachment #652580 - Attachment is obsolete: true
Attachment #652580 - Flags: review?(neil)
Attachment #657949 - Flags: review?(neil)
Comment on attachment 657949 [details] [diff] [review]
Use dragstart [Checked in: Comment 4]

Sigh, I couldn't get my Linux build to work with or without the patch but it works on my Windows build so it must be local bustage I guess...
Attachment #657949 - Flags: review?(neil) → review+
Comment on attachment 657949 [details] [diff] [review]
Use dragstart [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/6a88cb3ad733
Attachment #657949 - Attachment description: Use dragstart → Use dragstart [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-seamonkey2.15: --- → fixed
Flags: in-testsuite-
Flags: in-qa-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.15
You need to log in before you can comment on or make changes to this bug.