input text does not receive focus in viewer

VERIFIED FIXED in mozilla0.9.3

Status

()

Core
Event Handling
P2
critical
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: rods (gone), Assigned: Chris Waterson)

Tracking

Trunk
mozilla0.9.3
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
The bug # field doesn't take focus when I click on it in viewer. It works fine 
in mozilla.
(Reporter)

Comment 1

18 years ago
What is interesting is that when the bugzilla page loads the Bug # field 
automatically gets focus (imagine from JS). But of caorse this doesn't work, and 
as I stated earlier clicking doesn't work either.

I consider this a smoketest blocker until we can figure out why it doesn't work.

It work fine in Mozilla and MFCEmbed. It is BROKEN in winEmbed and viewer. 

I am wondering if this isn't some XBL thing.
Keywords: smoketest
(Reporter)

Comment 2

18 years ago
I set a breakpoint in the SetFocus method of nsHTMLInputElement.cpp and it is 
being called. So at least it thinks it ought to be getting focus.
(Reporter)

Comment 3

18 years ago
Here is something else strange. In mozilla, if I type in a bug # and the press 
"Show" it shows the bug. If I hit the "Back" button and then click in the Bug # 
field again the I-Beam cursor never shows, I can type in the field, so it does 
have focus.

Comment 4

18 years ago
Beppe should not have this.
Assignee: beppe → saari

Comment 5

18 years ago
Note that the multiline textbox (Additional Comments) does work. It's only
single line input field.

Comment 6

18 years ago
These changes were made 2 weeks ago. This is not a smoketest blocker. Follow 
what all the other embedding clients do.

Comment 7

18 years ago
It probably is some packaging or xbl exporting issue

Comment 8

18 years ago
This is caused because viewer has no activate logic like the embedding clients 
and SeaMonkey.  AFAIK, nobody has the time to write this logic for viewer, 
which makes me think it's time to retire viewer and move to the embedding 
clients as the primary testbeds.
Sounds like 76617 to me.

Comment 10

18 years ago
downgrading severity, if this is working in the embed test binaries *other* than 
 viewer (viewer isn't in the smoketests, either).
Severity: blocker → critical
Keywords: smoketest
I agree with hyatt on this.  It's time for viewer to die and to use other test beds.
(Reporter)

Comment 12

18 years ago
That is way easier said than done. Somebody needs to find the time to move the 
testing logic over.
Exactly what testing logic do you need moved?

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0

Comment 14

17 years ago
QA contact updated
QA Contact: gerardok → madhur
(Assignee)

Comment 15

17 years ago
Have patch; taking.
Assignee: saari → waterson
Status: ASSIGNED → NEW
(Assignee)

Comment 16

17 years ago
Created attachment 41684 [details] [diff] [review]
make input elements take focus
(Assignee)

Comment 17

17 years ago
saari helped me write this: the problem was that we weren't activating the focus
controller when the window got activated. So, the meat of the fix is in
nsBrowserWindow.cpp, and the other stuff is really just along for the ride.
(Maybe we'll want to make it work someday.)
Status: NEW → ASSIGNED
Keywords: patch
Priority: -- → P2
Target Milestone: mozilla1.0 → mozilla0.9.3

Comment 18

17 years ago
r/sr/pr/mr=attinasi
(Assignee)

Comment 19

17 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 20

17 years ago
verified on build 2001-07-30-10-trunck
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.