783449 - popup menus show highlighted item from last time they were open

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Cameron McCormack (:heycam)]

I don't know if this is a widget or gfx problem.  With current Nightlies on Mac, if I open a popup menu that I recently selected an item from, when it opens the last selected item is shown highlighted, when instead it should show no items highlighted.

STR:

1. Right click on a page's content.
2. Click View Page Info.
3. Close the Page Info window.
3. Right click again on the page's content.
4. Notice that View Page Info is initially highlighted, when it shouldn't be.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Please try to find a regression range among mozilla-central nightlies.

My hunch is that you'll find the 2012-08-14 nightly has this problem and the 2012-08-13 nightly doesn't.

Comment 2

[Cameron McCormack (:heycam)]

The first bad revision is:
changeset:   102212:22f6adf8685b
user:        Matt Woodrow <[e-mail]>
date:        Mon Aug 13 19:41:09 2012 -0700
files:       view/src/nsViewManager.cpp widget/gonk/nsWindow.cpp widget/gonk/nsWindow.h
description:
Bug 782413: Only paint widgets that have a layer manager. r=cjones

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Move the NeedsPaint code into android

This happens when we flush an invalid region to the widget, but don't actually paint anything.

This check was only really for android/gonk which have multiple widgets, but only ever paint one of them.

Comment 4

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f6cd8529ae9

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

are either this bug or bug 784137 dupes of bug 784117?

Comment 6

[Cameron McCormack (:heycam)]

I think they probably both are.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1f6cd8529ae9

Comment 9

[Benoit Girard (:BenWa)]

I'm actually still getting this for the first frame the awesomebar is openned :(. I'm guessing 17 is still affected as well.

https://dl.dropbox.com/u/10523664/Screenshots/bugzilla-awesomebar-open.mp4

Comment 10

[Alex Keybl [:akeybl]]

(In reply to Benoit Girard (:BenWa) from comment #9)
> I'm actually still getting this for the first frame the awesomebar is
> openned :(. I'm guessing 17 is still affected as well.
> 
> https://dl.dropbox.com/u/10523664/Screenshots/bugzilla-awesomebar-open.mp4

Any progress here? We'll likely untrack soon if this continues to go unfixed. It's not super critical for release.

Comment 11

[Benoit Girard (:BenWa)]

I don't see this anymore on 2012-10-03

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Looks like we're done here then, untracking.