783471 - When "webapps-unique-by-domain" is enabled, package app submission fails

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[Rob Hudson [:robhudson]]

The form error is, "An app already exists on this domain; only one app per domain is allowed."

Packaged apps shouldn't be checking for unique by domain at all.

Comment 1

[Fred Wenzel [:wenzel]]

Do we even still need this check? When is the single-domain requirement going away?

Comment 2

[Bill Walker [:bwalker] [@wfwalker]]

For now the one-app-per-Origin (not per domain) restriction persists.

Comment 3

[Rob Hudson [:robhudson]]

via bwalker in IRC, "for now, the one-app-per-origin restriction persists. but then, we have the philosophical question, "what is the origin of a packaged app?"

I'll fix the code so packaged apps don't hit the same origin check we do for hosted apps at least. Doing something more later for checking *something* for packaged apps can be another bug.

Comment 4

[[:fabrice] Fabrice Desré]

There's no user-facing origin for a packaged app, so you should not check that in the marketplace. (We generate a randomized one on the gecko side, but that's an implementation detail).

Comment 5

[Andy McKay]

Is there any way to uniquely identify a packaged app then?

Comment 6

[[:fabrice] Fabrice Desré]

Not when you just have the package. Would you need that?

Comment 7

[Andy McKay]

How do we identify it for an update?
Would we ever want to blocklist a packaged app?
If the app is deleted or removed from the marketplace, can one replace it?

Comment 8

[krupa raj[:krupa]]

(In reply to Andy McKay [:andym] from comment #7)
> How do we identify it for an update?
> Would we ever want to blocklist a packaged app?
> If the app is deleted or removed from the marketplace, can one replace it?

I filed bug 784199 to decide that :)

Comment 9

[[:fabrice] Fabrice Desré]

Well, for updates we keep track of the download url. I guess this could be used also to blocklist.

Comment 10

[Andy McKay]

Sadly, URLs aren't guaranteed to be constant for a few reasons. For receipts we use a unique ID that is known to the marketplace. That wouldn't stop people uploading the same packaged app multiple times though.

Comment 11

[Andy McKay]

https://etherpad.mozilla.org/packaged-apps

- What if app disappears from the marketplace and phone looks for an update? bsmith: I imagine it will just look like "no update available." What if a new app takes its place? bsmith: Apps are considered the "same app" if the app ID matches.

And a few more comments below.

Comment 12

[Rob Hudson [:robhudson]]

This commit bypasses the unique origin checking we do for hosted apps:
https://github.com/mozilla/zamboni/commit/134de78