783472 - Refactor recording notification code

Status: RESOLVED WORKSFORME

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Anant Narayanan [:anant]]

In bug 774581, code was added to fire the "recording-device-events" observer notification from both CameraControl and MediaManager. The event is fired whenever a MediaStream is started.

This code should be re-factored to only emit an observer event when no recording is occurring and one event when recording is occurring (for purposes of display on the UI, which is needed for all platforms). We can begin by doing this for Desktop, and eventually when CameraControl is merged into gUM (i.e. MediaManager), the B2G front-end can be ported as well.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

May not reall be blocking, but probably easy to fix

Comment 2

[Maire Reavy [:mreavy]]

Florian - is this still something we want, or would this break the UI code?

Comment 3

[Florian Quèze [:florian]]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #2)
> Florian - is this still something we want, or would this break the UI code?

I don't understand the actual goal of the proposed refactoring here, and given how old this code is, I suspect we've resolved the problems this was trying to solve in another way. Any change to recording-device-events notifications would likely need associated UI changes.