Last Comment Bug 783479 - Bug 560793 causes crash in nsNNTPProtocol::ProcessProtocolState
: Bug 560793 causes crash in nsNNTPProtocol::ProcessProtocolState
: regression
Product: MailNews Core
Classification: Components
Component: Networking: NNTP (show other bugs)
: Trunk
: x86 Windows 7
-- normal (vote)
: Thunderbird 17.0
Assigned To: Joshua Cranmer [:jcranmer]
Depends on:
Blocks: 560793
  Show dependency treegraph
Reported: 2012-08-16 23:48 PDT by Makoto Kato [:m_kato]
Modified: 2012-09-05 14:45 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Null-check the inputStream (2.05 KB, patch)
2012-08-17 16:16 PDT, Joshua Cranmer [:jcranmer]
neil: review+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image Makoto Kato [:m_kato] 2012-08-16 23:48:44 PDT
Since inputStream is nullptr, this crash occurs.  we need consider that inputStream (2nd param) is nullptr.


0 	xul.dll 	nsNNTPProtocol::ProcessProtocolState 	mailnews/news/src/nsNNTPProtocol.cpp:4411
1 	xul.dll 	nsNNTPProtocol::OnPromptCanceled 	mailnews/news/src/nsNNTPProtocol.cpp:2592
2 	xul.dll 	nsNNTPProtocol::OnPromptStart 	mailnews/news/src/nsNNTPProtocol.cpp:2564
3 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
4 	xul.dll 	XPCWrappedNative::CallMethod 	js/xpconnect/src/XPCWrappedNative.cpp:2409
5 	xul.dll 	XPC_WN_CallMethod 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1554
6 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:519
7 	mozjs.dll 	js::Interpret 	js/src/jsinterp.cpp:2757
8 	mozjs.dll 	JSScript::makeAnalysis 	js/src/jsinfer.cpp:5372
9 	mozjs.dll 	js::RunScript 	js/src/jsinterp.cpp:475
10 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:535
11 	mozjs.dll 	js::Invoke 	js/src/jsinterp.cpp:567
12 	mozjs.dll 	JS_CallFunctionValue 	js/src/jsapi.cpp:5429
13 	xul.dll 	nsXPCWrappedJSClass::CallMethod 	js/xpconnect/src/XPCWrappedJSClass.cpp:1509
14 	xul.dll 	nsXPCWrappedJS::CallMethod 	js/xpconnect/src/XPCWrappedJS.cpp:617
15 	xul.dll 	PrepareAndDispatch 	xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp:117
16 	xul.dll 	SharedStub 	xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp:144
17 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:656
Comment 1 User image Joshua Cranmer [:jcranmer] 2012-08-17 16:16:15 PDT
Created attachment 652975 [details] [diff] [review]
Null-check the inputStream

A patch.
Comment 2 User image 2012-08-17 17:33:32 PDT
So why wouldn't we want to pass mInputStream?
Comment 3 User image Joshua Cranmer [:jcranmer] 2012-08-17 18:08:42 PDT
mInputStream is only used in the case where we're being called from the timer callback in the LIST case, so it's only set in ReadNewsList.
Comment 4 User image 2012-08-18 15:03:03 PDT
Comment on attachment 652975 [details] [diff] [review]
Null-check the inputStream

Fair enough.
Comment 5 User image Joshua Cranmer [:jcranmer] 2012-08-19 07:54:55 PDT
Comment 6 User image Mark Banner (:standard8) 2012-08-20 01:39:32 PDT
This is a low-level crash in TB14, Joshua, should we advance this forward to 16, to push out the fix earlier?
Comment 7 User image Joshua Cranmer [:jcranmer] 2012-08-20 12:07:14 PDT
I see no problems doing so.
Comment 8 User image Mark Banner (:standard8) 2012-09-05 14:34:33 PDT
Comment on attachment 652975 [details] [diff] [review]
Null-check the inputStream

[Triage Comment]
This is already on aurora, but taking forward to beta/16 as per previous comments.
Comment 9 User image Mark Banner (:standard8) 2012-09-05 14:45:40 PDT
Checked in:

Note You need to log in before you can comment on or make changes to this bug.