783559 - WebGL resources are leaked when a page is reloaded

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Chris Lord [:cwiiis]]

If you load a page with a WebGL demo in Firefox Mobile, it appears that reloading does not free the resources associated with WebGL. Reloading multiple times will cause odd behaviour and crashing in fairly short order.

This may be a duplicate of bug #725145.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

How are you determining that resources are not being freed?

Comment 2

[Chris Lord [:cwiiis]]

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #1)
> How are you determining that resources are not being freed?

Not by any scientific means, but after a couple of reloads, texture/buffer creation starts to fail (so some may work fine, but once a certain point is reached, all fail), and usually after they fail, a further reload results in a crash. Not sure what else could cause this.

This is only on mobile, and I've only tested on a Galaxy Nexus. Desktop appears to be fine.

Comment 3

[Benoit Girard (:BenWa)]

Might be a good time to check and make sure we have COUNT_CTOR all over our webgl code.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Well, GL resources all get destroyed when the context is destroyed (assuming no gl context sharing).  Now, that context destruction is dependent upon GC, but still...

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

jgilbert, bjacob, or maybe benwa -- can one of you guys take a look at this and see if there's anything here?  I suspect this is just an issue of GC not firing enough during WebGL code, and it might have been fixed with bjacob's per-origin context counting stuff.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Any update on seeing if this is an issue?

Comment 7

[Kelsey Gilbert [:jgilbert]]

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #6)
> Any update on seeing if this is an issue?

No. I have some patches somewhere to redo the memory tracking for GL objects in a more robust spec-matching way.

I suspect comment#5 is correct in that the force-lose-context for many living GL contexts should alleviate this, but cannot by-itself wholly solve this.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Did the stuff in comment 7 ever land? If so, is there more that needs to be done here? Any other bugs that this depends on?