783652 - [B2G] All passwordmgr mochitests fail on B2G

Status: RESOLVED WONTFIX

(Toolkit :: Password Manager, defect)

Description

[Jonathan Griffin (:jgriffin)]

All passwordmgr mochitests fail on B2G with errors similar to the following:

/tests/toolkit/components/passwordmgr/test/test_basic_form.html
TEST-UNEXPECTED-FAIL | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "this._storage is null" {file: "jar:file:///system/b2g/omni.ja!/components/nsLoginManager.js" line: 407}]' when calling method: [nsILoginManager::getAllLogins] at http://mochi.test:8888/tests/toolkit/components/passwordmgr/test/pwmgr_common.js:141

For this reason, all such tests are being disabled for B2G runs.

Full log:  http://brasstacks.mozilla.com/autologserver/showlog?file=d1306d08-e894-11e1-ad87-22000af4836f.txt.gz

Comment 1

[Mounir Lamouri (:mounir)]

For the moment, this is an expected behaviour. We should disable those tests for B2G for the moment. Maybe we should even have a test checking that the password manager is disabled.

Comment 2

[Justin Dolske [:Dolske]]

Does B2G simply not include a password manager? Or does this mean there's an actual pwmgr breakage?

Comment 3

[Justin Dolske [:Dolske]]

._storage is a getter that should automatically try to init the storage backend... If that fails, it logs a message:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/nsLoginManager.js#67

  this.log("Initialization of storage component failed: " + e);

I'd be curious to know what's causing that. Can someone trigger a mochitest run of this with the signons.debug pref set to true?

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to Justin Dolske [:Dolske] from comment #2)
> Does B2G simply not include a password manager? Or does this mean there's an
> actual pwmgr breakage?

That means B2G doesn't include a password manager for the moment and this is going to stay like that for v1 for sure.

Comment 5

[Chris Lord [:cwiiis]]

Not having password management in b2g is a major pain. Having to constantly type out your user details and passwords isn't fun, and web sites/apps have a propensity to forget your login arbitrarily.

I think we should try to fix this for 2.2.

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Blocking Requested - why for this release]:
it's a feature so not a good idea to block 2.0 as it's FLR now.
Changing it to 3.0?

Comment 7

[Mahendra Potharaju [:mahe]]

Password manager is not in scope for 2.5. Not blocking 2.5 release

Comment 8

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Are tests still failing for B2G?

Is B2G still going to use Toolkit:Password Manager? 

May I close this?

Comment 9

[Jonathan Griffin (:jgriffin)]

I have no idea, passing to jcheng