If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Improve tab closing animation

RESOLVED INCOMPLETE

Status

()

Firefox
Tabbed Browser
RESOLVED INCOMPLETE
5 years ago
5 years ago

People

(Reporter: ttaubert, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 652872 [details] [diff] [review]
patch v1

While taking a closer look at the tab closing animation I noticed that right after the tab close animation finished there is a small flicker over the newtab-button.

I first changed |min/max-width: 0.1px| to |min/max-width: 0|. max-width shouldn't affect the border-width, that's why (on Linux) there's an 11px wide border left when the transition has finished. This actually shouldn't work with 0.1px either but maybe that's some strange bug? Anyway it seems like the border appears for a single frame again when the transition has finished and this disappeared when using |max-width: 0|.

Getting rid of the border is now pretty easy, we just transition border-left/right-width to zero as well. I changed the opacity transition to happen a little earlier as well so that it looks a little smoother and not so rushed.

Also, it would be interesting to see if the strange 0/0.1px behavior has something to do with bug 608589?
Attachment #652872 - Flags: review?(dao)
Comment on attachment 652872 [details] [diff] [review]
patch v1

As mentioned in bug 604735 comment 4, min-width:0 doesn't have the desired effect.

Rather than transitioning the border width, would -moz-box-sizing:border-box work here?
Attachment #652872 - Flags: review?(dao) → review-
(In reply to Dão Gottwald [:dao] from comment #1)
> Rather than transitioning the border width, would -moz-box-sizing:border-box
> work here?

That's actually the default in XUL...
Blocks: 593680
(Reporter)

Updated

5 years ago
Assignee: ttaubert → nobody

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.