783674 - Potential WebGLContext::Render issues

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

It looks like not only does  WebGLContext::Render not bind to the screen before ReadPixels, but it also doesn't Flush the gfxImageSurface (probably fine), and doesn't MarkDirty the surface. (probably not fine)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: patch

Switch to ReadScreen* and mark surfaces as dirty.

Comment 2

[Kelsey Gilbert [:jgilbert]]

We can probably make a POC for the framebuffer-dependent part of this bug:
Clear the WebGL screen to green, create and bind a framebuffer, and clear the framebuffer to red. Check that Render is showing the green one any number of ways. (toDataURL, upload canvas to a texture, draw canvas to a canvas)

This should be added to the conformance suite if it's not already there.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: patch

Unbitrotted, and we only should need to do the MarkDirty part now. The switch to ReadPixelsFromScreen happened elsewhere, and has tests.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/305da4132a7f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/305da4132a7f