Camera - always assume the camera gives us yuv420sp

RESOLVED FIXED

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mikeh, Assigned: mikeh)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

It appears we can't trust the Gonk camera API to reliably tell us what format the frames of the viewfinder stream are going to be in.  We already set 'yuv420p' and then read back the setting to see if it stuck, and up until now it never has.

On the LG Optimus L5, however, it looks like the setting -does- stick, but the camera continues to return 'yuv420sp' data anyway.

So we need a patch to just ignore what we read back from the camera, and always assume the frames are in 'yuv420sp'.

Comment 2

7 years ago
Comment on attachment 653393 [details] [diff] [review]
Force the camera to assume 'yuv420sp' regardless of what the library says

Please rename flag to "FORCE_PREVIEW_FORMAT_YUV420SP".
Attachment #653393 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/49123250304f
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.