show/hide events for social content

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

unspecified
Firefox 17
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

5 years ago
content in the status panels need show/hide events
(Assignee)

Comment 1

5 years ago
We'll use socialFrameShow/Hide for the event names.  We need to emit those events for the status panels, and update the event names for the sidebar.  bug 779923 (flyout panel) and bug 779686 (chat) will implement for their respective content frames.
Summary: status panel show/hide events → show/hide events for social content
(Assignee)

Updated

5 years ago
Assignee: nobody → mixedpuppy
(Assignee)

Comment 2

5 years ago
Created attachment 652984 [details] [diff] [review]
events patch

patch to add show/hide events for status panels and fix the event name for the sidebar.
Attachment #652984 - Flags: review?(jaws)
Attachment #652984 - Flags: review?(felipc)
I'm not sure that it matters that much in practice, but we should probably use popupshown rather than popupshowing for firing the "show" event (and we can use that for setting the "open" attribute too). One copy/pasto I noticed: the popupshowing handler is called "onpopuphiding".
(Assignee)

Comment 4

5 years ago
Created attachment 652998 [details] [diff] [review]
updated from comments
Attachment #652984 - Attachment is obsolete: true
Attachment #652984 - Flags: review?(jaws)
Attachment #652984 - Flags: review?(felipc)
Attachment #652998 - Flags: review?(gavin.sharp)
Attachment #652998 - Flags: review?(felipc)
Comment on attachment 652998 [details] [diff] [review]
updated from comments

I tweaked the test slightly to address the third issue I pointed out in bug 779360 comment 15, and ran into this problem:

TypeError: notifBrowser.contentDocument.documentElement is null at chrome://browser/content/browser.js:4173

Seems like we'll need to wait for DOMContentLoaded of the panel iframe before firing the "shown" event.
Attachment #652998 - Flags: review?(gavin.sharp)
Attachment #652998 - Flags: review?(felipc)
Attachment #652998 - Flags: review-
Created attachment 653410 [details] [diff] [review]
tweaks

Here's the patch I applied on top that revealed the problem.
(Assignee)

Comment 7

5 years ago
Created attachment 653448 [details] [diff] [review]
events patch

fixes show event to happen after load if the document is not loaded.
Attachment #652998 - Attachment is obsolete: true
Attachment #653410 - Attachment is obsolete: true
Attachment #653448 - Flags: review?(gavin.sharp)
Attachment #653448 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/e262e9e1a0b1
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → Firefox 17
https://hg.mozilla.org/mozilla-central/rev/e262e9e1a0b1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 784238
You need to log in before you can comment on or make changes to this bug.