Closed Bug 783691 Opened 7 years ago Closed 7 years ago

show/hide events for social content

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 17

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

(Whiteboard: [Fx17])

Attachments

(1 file, 3 obsolete files)

content in the status panels need show/hide events
We'll use socialFrameShow/Hide for the event names.  We need to emit those events for the status panels, and update the event names for the sidebar.  bug 779923 (flyout panel) and bug 779686 (chat) will implement for their respective content frames.
Summary: status panel show/hide events → show/hide events for social content
Assignee: nobody → mixedpuppy
Attached patch events patch (obsolete) — Splinter Review
patch to add show/hide events for status panels and fix the event name for the sidebar.
Attachment #652984 - Flags: review?(jaws)
Attachment #652984 - Flags: review?(felipc)
I'm not sure that it matters that much in practice, but we should probably use popupshown rather than popupshowing for firing the "show" event (and we can use that for setting the "open" attribute too). One copy/pasto I noticed: the popupshowing handler is called "onpopuphiding".
Attached patch updated from comments (obsolete) — Splinter Review
Attachment #652984 - Attachment is obsolete: true
Attachment #652984 - Flags: review?(jaws)
Attachment #652984 - Flags: review?(felipc)
Attachment #652998 - Flags: review?(gavin.sharp)
Attachment #652998 - Flags: review?(felipc)
Comment on attachment 652998 [details] [diff] [review]
updated from comments

I tweaked the test slightly to address the third issue I pointed out in bug 779360 comment 15, and ran into this problem:

TypeError: notifBrowser.contentDocument.documentElement is null at chrome://browser/content/browser.js:4173

Seems like we'll need to wait for DOMContentLoaded of the panel iframe before firing the "shown" event.
Attachment #652998 - Flags: review?(gavin.sharp)
Attachment #652998 - Flags: review?(felipc)
Attachment #652998 - Flags: review-
Attached patch tweaks (obsolete) — Splinter Review
Here's the patch I applied on top that revealed the problem.
Attached patch events patchSplinter Review
fixes show event to happen after load if the document is not loaded.
Attachment #652998 - Attachment is obsolete: true
Attachment #653410 - Attachment is obsolete: true
Attachment #653448 - Flags: review?(gavin.sharp)
Attachment #653448 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/integration/fx-team/rev/e262e9e1a0b1
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → Firefox 17
https://hg.mozilla.org/mozilla-central/rev/e262e9e1a0b1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Blocks: 784238
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.