Closed
Bug 783691
Opened 12 years ago
Closed 12 years ago
show/hide events for social content
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
(Whiteboard: [Fx17])
Attachments
(1 file, 3 obsolete files)
9.84 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
content in the status panels need show/hide events
Assignee | ||
Comment 1•12 years ago
|
||
We'll use socialFrameShow/Hide for the event names. We need to emit those events for the status panels, and update the event names for the sidebar. bug 779923 (flyout panel) and bug 779686 (chat) will implement for their respective content frames.
Summary: status panel show/hide events → show/hide events for social content
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mixedpuppy
Assignee | ||
Comment 2•12 years ago
|
||
patch to add show/hide events for status panels and fix the event name for the sidebar.
Attachment #652984 -
Flags: review?(jaws)
Attachment #652984 -
Flags: review?(felipc)
Comment 3•12 years ago
|
||
I'm not sure that it matters that much in practice, but we should probably use popupshown rather than popupshowing for firing the "show" event (and we can use that for setting the "open" attribute too). One copy/pasto I noticed: the popupshowing handler is called "onpopuphiding".
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #652984 -
Attachment is obsolete: true
Attachment #652984 -
Flags: review?(jaws)
Attachment #652984 -
Flags: review?(felipc)
Attachment #652998 -
Flags: review?(gavin.sharp)
Attachment #652998 -
Flags: review?(felipc)
Comment 5•12 years ago
|
||
Comment on attachment 652998 [details] [diff] [review] updated from comments I tweaked the test slightly to address the third issue I pointed out in bug 779360 comment 15, and ran into this problem: TypeError: notifBrowser.contentDocument.documentElement is null at chrome://browser/content/browser.js:4173 Seems like we'll need to wait for DOMContentLoaded of the panel iframe before firing the "shown" event.
Attachment #652998 -
Flags: review?(gavin.sharp)
Attachment #652998 -
Flags: review?(felipc)
Attachment #652998 -
Flags: review-
Comment 6•12 years ago
|
||
Here's the patch I applied on top that revealed the problem.
Assignee | ||
Comment 7•12 years ago
|
||
fixes show event to happen after load if the document is not loaded.
Attachment #652998 -
Attachment is obsolete: true
Attachment #653410 -
Attachment is obsolete: true
Attachment #653448 -
Flags: review?(gavin.sharp)
Updated•12 years ago
|
Attachment #653448 -
Flags: review?(gavin.sharp) → review+
Updated•12 years ago
|
Keywords: checkin-needed
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e262e9e1a0b1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•