_PR_DILEDESC_XXXSTATE should not be defined in pprio.h.

RESOLVED FIXED

Status

NSPR
NSPR
P3
normal
RESOLVED FIXED
19 years ago
18 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

19 years ago
The macros _PR_FILEDESC_OPEN, _PR_FILEDESC_CLOSED,
and _PR_FILEDESC_FREED are defined in private/pprio.h,
which is exported.  However, these three macros are
only used as the values of the fd->secret->state field,
which is in an internal structure (PRFilePrivate)
defined in primpl.h.  We should move the definitions
of these three macros to primpl.h, next to
the definition of struct PRFilePrivate.

Comment 1

19 years ago
Yes, this is a good change to make, for 3.5, and should be announced, in
advance, to nspr20 clients.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

18 years ago
I checked in the fix to the internal cvs repository.
/m/src/ns/nspr20/pr/include/private/pprio.h, revision 2.11
/m/src/ns/nspr20/pr/include/private/primpl.h, revision 2.62
(Assignee)

Updated

18 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

18 years ago
The fix has been merged to cvs.mozilla.org.
You need to log in before you can comment on or make changes to this bug.