Closed Bug 783702 Opened 7 years ago Closed 7 years ago

getElementIfPresent ends up invoking non-own |has| trap on proxy with hasPrototype()

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: bholley, Assigned: bholley)

References

Details

(Whiteboard: [js:t])

Attachments

(1 file)

We assert in DirectWrapper that we're only invoking own traps on the object if hasPrototype() is true. But the implementation getElementIfPresent in BaseProxyHandler calls has(), which violates this assumption. This causes us to assert. Patch coming right up.
Whiteboard: [js:t]
Attachment #652959 - Flags: review+
Attachment #652959 - Flags: review?(ejpbruel)
This was partially orange because of the other patch pushed alongside it to try, but I don't see any failures that look related to this patch. Pushing to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d8bdbcc40f9
https://hg.mozilla.org/mozilla-central/rev/3d8bdbcc40f9
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Test coverage here is possible, but it's not very high on my priority list.
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.