783742 - Add support for WPS PIN method

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, enhancement)

Description

[Masashi Honma]

Attachment: patch for WPS PIN

This patch adds support for WPS PIN method.
The PIN code is generated by wpa_supplicant or inputted via the gaia UI.
This patch supports both.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 653024 [details] [diff] [review]
patch for WPS PIN

Review of attachment 653024 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, other than a couple of nits. Masashi, if you attach a new patch with the nits corrected, I'll land it tomorrow.

::: dom/wifi/WifiWorker.js
@@ +279,5 @@
>    }
>  
> +  function wpsPinCommand(pin, callback) {
> +    doStringCommand("WPS_PIN any" + (pin === undefined ? "" : (" " + pin)),
> +      callback);

Nitpick: please indent callback to the same level as the first quote in the line above it.

@@ +2113,5 @@
>            self._sendMessage(message, false, "WPS Cancel failed", rid, mid);
>        });
>      } else {
> +      self._sendMessage(message, false, "Invalid WPS method=" + detail.method,
> +        rid, mid);

Same thing here (though I missed it the first time around): please indent rid to the same level as "message".

Comment 2

[Masashi Honma]

Attachment: second patch

Comment 3

[Masashi Honma]

Thanks for your review.

I attached a new patch.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f921ed75d75d

Thanks again.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4666c4ccea09