783754 - Flash does not work on the Samsung Galaxy SII

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[percipee23]

User Agent: Mozilla/5.0 (Android; Mobile; rv:15.0) Gecko/15.0 Firefox/15.0
Build ID: 20120814223533

Steps to reproduce:

it started with recent updates


Actual results:

it started with the recent updates. it was working fine when i downloaded it for the first time until the recent updates

Comment 1

[Catalin Suciu [:csuciu]]

I am able to reproduce this issue using the latest Nightly on Samsung Galaxy SII with Android 4.0.3


Regression:
Good build: Nightly 16.0a1 24/07/2012
Bad build: Nightly 16.0a1 25/07/2012

Possible range
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3613cbdc3481&tochange=ef20925bc2a5

Comment 2

[Aaron Train [:aaronmt]]

(In reply to Catalin Suciu from comment #1)
> I am able to reproduce this issue using the latest Nightly on Samsung Galaxy
> SII with Android 4.0.3
> 
> 
> Regression:
> Good build: Nightly 16.0a1 24/07/2012
> Bad build: Nightly 16.0a1 25/07/2012
> 
> Possible range
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=3613cbdc3481&tochange=ef20925bc2a5

Can this be shortened using tinderbox-builds?

I see bug 687267 in there.

Comment 3

[Aaron Train [:aaronmt]]

I/Gecko   ( 4483): === SHADER COMPILATION FAILED ===
I/Gecko   ( 4483): === Source:
I/Gecko   ( 4483): /* sRGBATextureLayerExternalFS */
I/Gecko   ( 4483): /* Fragment Shader */
I/Gecko   ( 4483): #ifdef GL_ES
I/Gecko   ( 4483): precision lowp float;
I/Gecko   ( 4483): #endif
I/Gecko   ( 4483): 
I/Gecko   ( 4483): #ifndef NO_LAYER_OPACITY
I/Gecko   ( 4483): uniform float uLayerOpacity;
I/Gecko   ( 4483): #endif
I/Gecko   ( 4483): #ifdef GL_ES // for tiling, texcoord can be greater than the lowfp range
I/Gecko   ( 4483): varying mediump vec2 vTexCoord;
I/Gecko   ( 4483): #else
I/Gecko   ( 4483): varying vec2 vTexCoord;
I/Gecko   ( 4483): #endif
I/Gecko   ( 4483): 
I/Gecko   ( 4483): #extension GL_OES_EGL_image_external : require
I/Gecko   ( 4483): uniform samplerExternalOES uTexture;
I/Gecko   ( 4483): uniform mat4 uTextureTransform;
I/Gecko   ( 4483): void main()
I/Gecko   ( 4483): {
I/Gecko   ( 4483): float mask = 1.0;
I/Gecko   ( 4483): 
I/Gecko   ( 4483): gl_FragColor = texture2D(uTexture, (uTextureTransform * vec4(vTexCoord.x, vTexCoord.y, 0.0, 1.0)).xy) * uLayerOpacity * mask;
I/Gecko   ( 4483): }
I/Gecko   ( 4483): 
I/Gecko   ( 4483): === Log:
I/Gecko   ( 4483): 0:16: P0007: Extension directive must occur before any non-preprocessor tokens
I/Gecko   ( 4483): 0:17: L0001: Typename expected, found 'samplerExternalOES'
I/Gecko   ( 4483): ============

Comment 4

[Aaron Train [:aaronmt]]

Attachment: Nightly (08/23) raw log

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Fix Flash on the Galaxy SII

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/679fcc8f57d0

Comment 7

[Aaron Train [:aaronmt]]

Tested custom Fennec build in channel and it worked (i9100/4.0.4)

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

If this is a verifiable fix, let's get it uplifted and we can spin a mobile-only b7 today, verify there and then ship that tomorrow.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 654645 [details] [diff] [review]
Fix Flash on the Galaxy SII

[Approval Request Comment]
Low risk, makes flash work once again on a very popular device

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 654645 [details] [diff] [review]
Fix Flash on the Galaxy SII

Great, thanks for the fast turnaround on this, let's get it landed to branches.

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f0ce5d7281c3
https://hg.mozilla.org/releases/mozilla-beta/rev/b341598d33da

Comment 12

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/679fcc8f57d0

Comment 13

[Catalin Suciu [:csuciu]]

I verified the bug by playing adds on www.cnn.com and video on www.intel.com/museumofme

Verified fixed on:
Nightly 17.0a1 (24-08-2012)
Aurora 16.0a2 (24-08-2012)
Beta 15.0b7 Build 1