783791 - When re-launching Firefox into maximized window, tabs start out below Firefox button and then shift up to the titlebar

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Asa Dotzler [:asa]]

(note, this is not the same as bug 763269)

On Windows 7, with the latest nightly build (and possibly releases) if you exit Firefox from a maximized window and then re-launch, there is a split second where tabs are below the Firefox button in their own tab strip before they shift up to the titlebar where they're supposed to be. This is really quite ugly and makes Firefox feel very slow. I'm asserting this is a snappy:p1 because users see it every time they start and start-up time is our number one performance complaint.

Comment 1

[Dão Gottwald [:dao]]

This is a recent regression.

Comment 2

[Asa Dotzler [:asa]]

We shouldn't ship this regression. QA, can you help us find the regression window?

Comment 3

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/c14e2d5f17de
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120813105346
Bad:
http://hg.mozilla.org/mozilla-central/rev/75cdb3f932c6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120813110945
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c14e2d5f17de&tochange=75cdb3f932c6


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/ed614ea130c0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120813024745
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6a0b53d78465
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120813031248
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ed614ea130c0&tochange=6a0b53d78465

Comment 4

[Asa Dotzler [:asa]]

(In reply to Alice0775 White from comment #3)

Thank you, Alice0775!  Matt, can you look into this? This is a severe enough regression that we need a fix or a back out before we uplift to Aurora.

Comment 5

[Alice0775 White]

Last good: 6723b36d8bfa
First bad : 0ad204385022

triggered by:
0ad204385022	Matt Woodrow — Bug 770000 - Call WillPaint and DidPaint from the refresh driver instead of the widget events. r=roc

Comment 6

[Matt Woodrow (:mattwoodrow)]

I can reproduce this with the nightly, but not with the latest mozilla-inbound build.

I think this is probably fixed by bug 782980 which landed today.