783795 - locationbar, personalbar, menubar, statusbar, and toolbar are true in a webapp - should be false

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P2)

Description

[Jason Smith [:jsmith]]

Steps:

1. Go to http://ed.agadak.net/app
2. Install the web app
3. Launch it

Expected:

The locationbar, personalbar, menubar, statusbar, and toolbar values should all be false in a web app.

Actual:

Those values are all true. This prevents a web app from detecting when to show navigation or not if this is true.

Comment 1

[Aaron Train [:aaronmt]]

What are these properties and are they relevant to mobile?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Aaron Train [:aaronmt] from comment #1)
> What are these properties and are they relevant to mobile?

Location Bar: https://developer.mozilla.org/en-US/docs/DOM/window.locationbar
Menu Bar: https://developer.mozilla.org/en/DOM/window.menubar
Personal Bar: https://developer.mozilla.org/en/DOM/window.personalbar
Status Bar: https://developer.mozilla.org/en/DOM/window.statusbar
Toolbar: https://developer.mozilla.org/en/DOM/window.toolbar

The one that's relevant specifically is window.locationbar.visible - It's what we are advertising in our dev docs as a way for an app developer to detect when to show explicit navigation.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Looks like we could make the same change here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/BrowserCLH.js#103

Just need to change the flags based on "pinned"

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch simply controls adding "all" to the openWindow flags.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04e1aafc9d7c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04e1aafc9d7c

Comment 7

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-03-15)
-device: Acer Iconia A500
-OS: Android 3.2.1