783835 - Compositor needs to know the css property being animated

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Zbarsky (:dzbarsky)]

This is needed since some properties have different interpolation rules.

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 653118 [details] [diff] [review]
Patch

Review of attachment 653118 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that fixed.

::: gfx/layers/ipc/CompositorParent.cpp
@@ +658,5 @@
>      SampleValue(portion, animation, animData.mStartValues[segmentIndex],
>                  animData.mEndValues[segmentIndex], &interpolatedValue);
>      ShadowLayer* shadow = aLayer->AsShadowLayer();
>      switch (interpolatedValue.type()) {
> +    case Animatable::Tfloat:

Shouldn't we switch on the property name here, not the type?

Comment 3

[David Zbarsky (:dzbarsky)]

Yes, good catch.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4714af49469

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e4714af49469