Compositor needs to know the css property being animated

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is needed since some properties have different interpolation rules.
(Assignee)

Comment 1

5 years ago
Created attachment 653118 [details] [diff] [review]
Patch
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #653118 - Flags: review?(roc)
Comment on attachment 653118 [details] [diff] [review]
Patch

Review of attachment 653118 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that fixed.

::: gfx/layers/ipc/CompositorParent.cpp
@@ +658,5 @@
>      SampleValue(portion, animation, animData.mStartValues[segmentIndex],
>                  animData.mEndValues[segmentIndex], &interpolatedValue);
>      ShadowLayer* shadow = aLayer->AsShadowLayer();
>      switch (interpolatedValue.type()) {
> +    case Animatable::Tfloat:

Shouldn't we switch on the property name here, not the type?
Attachment #653118 - Flags: review?(roc) → review+
(Assignee)

Updated

5 years ago
Blocks: 783893
(Assignee)

Comment 3

5 years ago
Yes, good catch.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4714af49469
https://hg.mozilla.org/mozilla-central/rev/e4714af49469
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 831791
You need to log in before you can comment on or make changes to this bug.