Last Comment Bug 783840 - Fix build warnings in js
: Fix build warnings in js
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla17
Assigned To: David Zbarsky (:dzbarsky)
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: buildwarning
  Show dependency treegraph
Reported: 2012-08-18 19:10 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-08-21 06:31 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (8.84 KB, patch)
2012-08-18 19:11 PDT, David Zbarsky (:dzbarsky)
luke: review+
Details | Diff | Splinter Review

Description User image David Zbarsky (:dzbarsky) 2012-08-18 19:10:14 PDT

Comment 1 User image David Zbarsky (:dzbarsky) 2012-08-18 19:11:30 PDT
Created attachment 653122 [details] [diff] [review]
Comment 2 User image Luke Wagner [:luke] 2012-08-20 09:09:36 PDT
Comment on attachment 653122 [details] [diff] [review]

Nice, thanks.

One nit: can you use map->has(key) in jsweakmap.cpp?
Comment 3 User image David Zbarsky (:dzbarsky) 2012-08-20 09:34:46 PDT
Comment 4 User image Ed Morley [:emorley] 2012-08-21 06:31:52 PDT

Note You need to log in before you can comment on or make changes to this bug.