Last Comment Bug 783856 - Autogen PopupBlockedEvent
: Autogen PopupBlockedEvent
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on: 783376
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-19 00:35 PDT by Olli Pettay [:smaug]
Modified: 2012-08-20 14:08 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (13.33 KB, patch)
2012-08-19 00:35 PDT, Olli Pettay [:smaug]
jst: review+
Details | Diff | Splinter Review
up-to-date (13.32 KB, patch)
2012-08-20 11:26 PDT, Olli Pettay [:smaug]
no flags Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2012-08-19 00:35:10 PDT
Created attachment 653151 [details] [diff] [review]
patch

The patch makes mRequestingWindow strong, but cycle collected.

I re-ordered the attributes of nsIDOMPopupBlockedEvent so that
the interface, its Init*Event and dictionary all have the stuff in same order.
Codegen relies on the order currently.
Comment 1 Olli Pettay [:smaug] 2012-08-20 11:26:16 PDT
Created attachment 653446 [details] [diff] [review]
up-to-date
Comment 2 Olli Pettay [:smaug] 2012-08-20 14:08:26 PDT
https://hg.mozilla.org/mozilla-central/rev/360ab7771e27

Note You need to log in before you can comment on or make changes to this bug.