783872 - Don't pass ints to NS_FAILED

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

This makes c-c compile again with the nsresult enum patch, after NS_FAILED was made a function.

Comment 2

[:Irving Reid (No longer working on Firefox)]

Comment on attachment 653164 [details] [diff] [review]
Patch

Review of attachment 653164 [details] [diff] [review]:
-----------------------------------------------------------------

I should have caught this in reviewing the previous patch that changed the type of 'status' to int - all the methods we call and assign to status return nsresult (except one, as noted below), so I don't think we should have changed the type in the first place.

::: mailnews/compose/src/nsMsgSend.cpp
@@ +1169,5 @@
>    ma->m_current_column = 0;
>  
>    if (ma->m_type.LowerCaseEqualsLiteral(MESSAGE_RFC822) ||
>        ma->m_type.LowerCaseEqualsLiteral(MESSAGE_NEWS)) {
>      status = part->SetStripSensitiveHeaders(true);

This is the only call that returns int, and it always returns 0: https://mxr.mozilla.org/comm-central/source/mailnews/compose/src/nsMsgSendPart.h#48

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch v2

This does look much nicer!  Try: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=5b0ca67e7121

Comment 4

[:Irving Reid (No longer working on Firefox)]

Comment on attachment 655952 [details] [diff] [review]
Patch v2

Aryeh, thanks for going through all this. If we should ever find ourselves in the same location I will ply you with all the food and drink...

Comment 5

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I was told the try looks green by c-c standards, so . . .

https://hg.mozilla.org/comm-central/rev/42f4032b56a9