Closed
Bug 783879
Opened 12 years ago
Closed 12 years ago
Sub-optimal SQL query when displaying tags in buglists
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
498 bytes,
patch
|
wicked
:
review+
|
Details | Diff | Splinter Review |
In bug 616192, I stupidly copied the code for flags to add tags in buglists. But for tags, there is no need to concatenate strings together (for flags, you have to concatenate e.g. "review" and "+" together to create "review+"). This makes Oracle to fail with "ORA-00909: invalid number of arguments". This is harmless for MySQL and PostgreSQL, but still a useless call to the concatenation functions. Only 4.3.x is affected.
Attachment #653176 -
Flags: review?(timello)
Attachment #653176 -
Flags: review?(dkl)
Flags: blocking4.4+
|
||
Comment 1•12 years ago
|
||
Comment on attachment 653176 [details] [diff] [review] patch, v1 Seems reasonable as there's only one string.
Attachment #653176 -
Flags: review?(timello)
Attachment #653176 -
Flags: review?(dkl)
Attachment #653176 -
Flags: review+
|
Assignee | |
Updated•12 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/Search.pm Committed revision 8353.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•