Clean up async animation code

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Blocks: 780692
(Assignee)

Updated

5 years ago
Depends on: 783835
(Assignee)

Comment 1

5 years ago
Created attachment 653610 [details] [diff] [review]
Patch

If the main thread freezes while we're in visibility:none, then we never create a layer, so we won't start the animation.  This is no worse than what we do currently, but perhaps we should force a layer if there is a visibility animation.
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #653610 - Flags: review?(roc)
(Assignee)

Comment 2

5 years ago
Will do bug 784239 instead.  Morphing this bug.
Summary: Interpolate Visibility on the compositor rather than relying on layout to handle it → Clean up async animation code
(Assignee)

Comment 3

5 years ago
Created attachment 653632 [details] [diff] [review]
Patch

Clean up hunks.
Attachment #653610 - Attachment is obsolete: true
Attachment #653610 - Flags: review?(roc)
Attachment #653632 - Flags: review?(roc)
Attachment #653632 - Flags: review?(roc) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8e82fcec23b

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d8e82fcec23b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.