Last Comment Bug 783893 - Clean up async animation code
: Clean up async animation code
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: David Zbarsky (:dzbarsky)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on: 783835
Blocks: 780692
  Show dependency treegraph
 
Reported: 2012-08-19 10:13 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-08-21 06:27 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (22.68 KB, patch)
2012-08-20 18:16 PDT, David Zbarsky (:dzbarsky)
no flags Details | Diff | Splinter Review
Patch (15.10 KB, patch)
2012-08-20 19:45 PDT, David Zbarsky (:dzbarsky)
roc: review+
Details | Diff | Splinter Review

Description David Zbarsky (:dzbarsky) 2012-08-19 10:13:14 PDT

    
Comment 1 David Zbarsky (:dzbarsky) 2012-08-20 18:16:56 PDT
Created attachment 653610 [details] [diff] [review]
Patch

If the main thread freezes while we're in visibility:none, then we never create a layer, so we won't start the animation.  This is no worse than what we do currently, but perhaps we should force a layer if there is a visibility animation.
Comment 2 David Zbarsky (:dzbarsky) 2012-08-20 19:12:36 PDT
Will do bug 784239 instead.  Morphing this bug.
Comment 3 David Zbarsky (:dzbarsky) 2012-08-20 19:45:45 PDT
Created attachment 653632 [details] [diff] [review]
Patch

Clean up hunks.
Comment 4 David Zbarsky (:dzbarsky) 2012-08-20 21:07:38 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8e82fcec23b
Comment 5 Ed Morley [:emorley] 2012-08-21 06:27:41 PDT
https://hg.mozilla.org/mozilla-central/rev/d8e82fcec23b

Note You need to log in before you can comment on or make changes to this bug.