inline manifest viewer (and validator) fails on some manifests

VERIFIED FIXED in 2012-08-23

Status

Marketplace
Validation
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: eviljeff, Assigned: cvan)

Tracking

2012-08-23
Points:
---

Details

(URL)

(Reporter)

Description

6 years ago
The inline manifest viewer is failing to retrieve certain manifests (its returning a 500 error).  Similarly the validator is failing during its daily re-check.

(Despite the similar summary I don't think its related to bug 771101 as there doesn't seem to be any unicode)

URL included is an example, but there are some others as well.

This is the inline viewer url that's 500'ing:
https://marketplace.mozilla.org/en-US/reviewers/apps/review/mssgs/manifest?_=1345465213684
(Assignee)

Comment 1

6 years ago
http://sentry.dmz.phx1.mozilla.com/marketplace/group/1424/



TypeError: SSLError(SSLError(CertificateError("hostname 'mss.gs' doesn't match either of 'cp.etopiasms.nl', 'etopiasms.nl'",),),) is not JSON serializable

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "amo/decorators.py", line 29, in wrapper
    return func(request, *args, **kw)

  File "amo/decorators.py", line 61, in wrapper
    return f(request, *args, **kw)

  File "addons/decorators.py", line 32, in wrapper
    return f(request, addon, *args, **kw)

  File "amo/decorators.py", line 132, in wrapper
    status_code=status_code)

  File "amo/decorators.py", line 117, in json_response
    response = json.dumps(response)

  File "json/__init__.py", line 230, in dumps
    return _default_encoder.encode(obj)

  File "json/encoder.py", line 367, in encode
    chunks = list(self.iterencode(o))

  File "json/encoder.py", line 309, in _iterencode
    for chunk in self._iterencode_dict(o, markers):

  File "json/encoder.py", line 275, in _iterencode_dict
    for chunk in self._iterencode(value, markers):

  File "json/encoder.py", line 317, in _iterencode
    for chunk in self._iterencode_default(o, markers):

  File "json/encoder.py", line 323, in _iterencode_default
    newobj = self.default(o)

  File "json/encoder.py", line 344, in default
    raise TypeError(repr(o) + " is not JSON serializable")
Assignee: nobody → cvan
Target Milestone: --- → 2012-08-23
(Reporter)

Comment 2

6 years ago
For reference, these are the other two apps that I can find that also fail, where the manifest appears fine when downloaded manually/installed:

https://marketplace.mozilla.org/en-US/reviewers/apps/review/noodletalk
https://marketplace.mozilla.org/en-US/reviewers/apps/review/blossom

There are also other apps that have failed where the host is unreachable, etc.  Having the exact error would be a lot more useful to feed back to the developer.
(Assignee)

Comment 3

6 years ago
% curl -I https://noodletalk.org/noodletalk.webapp
HTTP/1.1 301 Moved Permanently
Server: nginx/1.3.2
Date: Mon, 20 Aug 2012 16:21:13 GMT
Content-Type: text/html
Content-Length: 184
Connection: keep-alive
Location: http://noodletalk.org/noodletalk.webapp

% curl -I https://www.blossom.io/moz-store.json
HTTP/1.1 200 OK
Content-Type: application/x-web-app-manifest+json
Date: Mon, 20 Aug 2012 16:21:48 GMT
Server: Google Frontend

Are redirects valid?
(Assignee)

Comment 4

6 years ago
https://github.com/mozilla/zamboni/commit/50904f2

I'm now ignoring checking SSL certs. Also, if we want to fail on redirects, that's a separate issue.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
I filed bug 784727 

But https://marketplace.mozilla.org/en-US/reviewers/apps/review/mssgs/manifest?_=1345465213684 doesn't 500 anymore.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.