Note: There are a few cases of duplicates in user autocompletion which are being worked on.

missing whitespace between icon and label in chat

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 18.0
x86_64
Linux
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 653389 [details]
screemhot of the issue

works as it should on the other toolbars
(Assignee)

Comment 1

5 years ago
Created attachment 653420 [details] [diff] [review]
patch to fix the issue

This adds mode="full" to the chat toolbar, making it behave like the other toolbars.
(Assignee)

Comment 2

5 years ago
Created attachment 653421 [details]
screeenshot of patch in action
Comment on attachment 653420 [details] [diff] [review]
patch to fix the issue

Seems to fix it, based on the screenshot, and the patch makes sense.  r=me, ui-r=me.

Later,
Blake.
Attachment #653420 - Flags: ui-review+
Attachment #653420 - Flags: review+
Andreas did we forget this bug? It still applies, so checkin-needed.

Would you ask for approval-comm-aurora to be in TB 17?
Keywords: checkin-needed
(In reply to Richard Marti [:Paenglab] from comment #4)
> Andreas did we forget this bug?

By the way, the screen shot here was on Linux, but I think we have the same bug or a similar issue on the non-aero version of the Windows theme. That's what it seems on some screenshots I saw on random forums at least (https://d37wxxhohlp07s.cloudfront.net/s3_images/785748/problem%20TB%20chat.JPG?1346408239 for an example).

> Would you ask for approval-comm-aurora to be in TB 17?

I would. Maybe even comm-beta for Tb16.
(In reply to Florian Quèze [:florian] [:flo] from comment #5)
> By the way, the screen shot here was on Linux, but I think we have the same
> bug or a similar issue on the non-aero version of the Windows theme. That's
> what it seems on some screenshots I saw on random forums at least
> (https://d37wxxhohlp07s.cloudfront.net/s3_images/785748/problem%20TB%20chat.
> JPG?1346408239 for an example).

I don't see this on XP. I have the mode=full on the toolbar (TB18). But this patch isn't Linux only, it affects also the other platforms and should also solve the issue on your screenshot.
https://hg.mozilla.org/comm-central/rev/c5da5372bcef

Andreas, please make sure that your hg is configured to generate all the necessary patch metadata. It makes life easier for those checking in on your behalf.
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.