Remove code to remove stylesheets and style tags from document in readability.js

VERIFIED FIXED in Firefox 16

Status

()

VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 17
All
Android
Points:
---

Firefox Tracking Flags

(firefox16 verified, firefox17 verified, firefox18 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We don't use the original document in reader. No need to care about stylesheets in the original document.
(Assignee)

Comment 1

6 years ago
Created attachment 653399 [details] [diff] [review]
No need to remove stylesheets and style tags in Readability.js
Attachment #653399 - Flags: review?(bnicholson)
Attachment #653399 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 3

6 years ago
I should have only removed the part that removes stylesheets from the document. Some pages add style tags inside the body and is causing problems to the candidate score calculation. I'll put this code back.

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/650fedd0f930
https://hg.mozilla.org/mozilla-central/rev/ae40b8512ddf
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
(Assignee)

Comment 6

6 years ago
Comment on attachment 653399 [details] [diff] [review]
No need to remove stylesheets and style tags in Readability.js

[Approval Request Comment]
User impact if declined: Unnecessary overhead when checking readability of pages.
Testing completed (on m-c, etc.): Landed in m-c, no regressions.
Risk to taking this patch (and alternatives if risky): Very low, just removes unnecessary code.
String or UUID changes made by this patch: None.
Attachment #653399 - Flags: approval-mozilla-aurora?
Attachment #653399 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

6 years ago
status-firefox16: --- → fixed
The code was cleaned up on the latest Nightly, Aurora and Beta builds. Closing bug as verified fixed.

--
Device: Galaxy Note
OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox16: fixed → verified
status-firefox17: --- → verified
status-firefox18: --- → verified
You need to log in before you can comment on or make changes to this bug.