784052 - Windows Error: File already exists in install-tp5n mozharness step

Status: RESOLVED WONTFIX

(Testing Graveyard :: Peptest, defect)

Description

[Andrew Halberstadt [:ahal]]

I believe this is due to the fact that on Windows doing "copy('foo', '/bar/')" will try to rename 'foo' to 'bar' rather than place 'foo' inside 'bar' (which is what happens on Unix).

Traceback (most recent call last):
  File "scripts/scripts/peptest.py", line 297, in <module>
    peptest.run()
  File "C:\talos-slave\test\scripts\mozharness\base\script.py", line 620, in run
    self._possibly_run_method(method_name, error_if_missing=True)
  File "C:\talos-slave\test\scripts\mozharness\base\script.py", line 591, in _possibly_run_method
    return getattr(self, method_name)()
  File "scripts/scripts/peptest.py", line 183, in install_tp5n
    log_level=DEBUG)
  File "C:\talos-slave\test\scripts\mozharness\base\script.py", line 166, in move
    shutil.move(src, dest)
  File "c:\mozilla-build\python25\Lib\shutil.py", line 196, in move
    copytree(src, dst, symlinks=True)
  File "c:\mozilla-build\python25\Lib\shutil.py", line 110, in copytree
    os.makedirs(dst)
  File "C:\mozilla-build\python25\lib\os.py", line 166, in makedirs
    mkdir(name, mode)
WindowsError: [Error 17] Cannot create a file when that file already exists: 'C:\\talos-slave\\test\\build\\tests\\peptest\\tests/firefox/server'

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Fix windows error

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 653403 [details] [diff] [review]
Patch 1.0 - Fix windows error

LGTM

Comment 3

[Andrew Halberstadt [:ahal]]

No longer running peptests in mozharness