784203 - Firefox logo should not be cropped on about:home on tablets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Firefox logo gets cropped on about:home on tablets due to padding around it. This should be cropped only for phones.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch replaces the images and adds few tweaks to the layout files.

Comment 2

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1c6b8695e5e

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 653580 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New UI.
User impact if declined: The logo looks cropped on tablets.
Testing completed (on m-c, etc.): Landed on m-i on 08/20
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 653580 [details] [diff] [review]
Patch

mobile only and minor

Comment 5

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/08d03be346d4

And to beta:
 https://hg.mozilla.org/releases/mozilla-beta/rev/b691cd9c10dd

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b1c6b8695e5e