784220 - B2G telephony: expose call waiting status

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Casey Yee]

The ability to retrieve Call Waiting status (whether on/off)
The ability to set Call Waiting on/off.

Incoming call behavior:
Call Waiting Toggled On - User will be able to accept incoming calls while on another active call.

Call Waiting Toggled Off - Incoming calls will return busy signal while on another active call.

It is proposed that we will add the toggle to the Settings -> Cellular & Data.

Github issue: https://github.com/mozilla-b2g/gaia/issues/3227

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch

Expose call waiting status & control call waiting status via Settings API

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> Created attachment 654153 [details] [diff] [review]
> Patch
> 
> Expose call waiting status & control call waiting status via Settings API

Changes to gaia/build/settings.js
https://github.com/hsinyi/gaia/commit/e85efbd787d38f5eed08d4f97670f1f2b750e705

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

The original gaia issue was marked as blocking-basecamp+.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 654153 [details] [diff] [review]
Patch

Obsolete this because there's rilrequest error when I tested in Brazil.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch (v2)

expose call waiting status & configure it by settings service

Comment 6

[Philipp von Weitershausen [:philikon]]

Comment on attachment 656459 [details] [diff] [review]
Patch (v2)

Review of attachment 656459 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Comments below (and also discussed vis-a-vis)

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +690,5 @@
> +      return;
> +    }
> +
> +    this.callWaitingStatus = newStatus;
> +    this._ensureCallWaitingStatus();

This can send us into a loop of RIL parcels trying to set the status in vain. If the network and our setting don't agree after trying to set the status, let's change the setting.

::: dom/system/gonk/nsIRadioInterfaceLayer.idl
@@ +254,5 @@
>  
>    readonly attribute nsIRilContext rilContext;
>  
> +  attribute bool callWaitingEnabled;
> +

I don't think we need this here, just listening to the Settings change is enough.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch (v3)

Comment 6 addressed.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch (v4): get/set ril.callwaiting.enabled

Control call waiting status by settings API.

Add a new setting "ril.callwaiting.enabled" 
https://github.com/hsinyi/gaia/commit/f88dc4e3f1fe46fc1bbc22fa070a84b1d30f4765

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 658429 [details] [diff] [review]
Patch (v4): get/set ril.callwaiting.enabled

Comment 6 addressed:
1) remove attribute callWaitingEnabled in .idl
2) reset 'ril.callwaiting.enabled' when RIL reports error

Thanks!

Comment 10

[Philipp von Weitershausen [:philikon]]

Comment on attachment 658429 [details] [diff] [review]
Patch (v4): get/set ril.callwaiting.enabled

Review of attachment 658429 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +3634,5 @@
>  RIL[REQUEST_SET_CALL_FORWARD] = null;
>  RIL[REQUEST_QUERY_CALL_WAITING] = null;
> +RIL[REQUEST_SET_CALL_WAITING] = function REQUEST_SET_CALL_WAITING(length, options) {
> +  options.success = options.rilRequestError == 0 ? true : false;
> +  options.rilMessageType = "callwaitingstatuschange";

You don't necessarily have to change `rilMessageType`. Just use

  switch "setCallWaiting":

in RadioInterfaceLayer. r=me with that.

Comment 11

[Philipp von Weitershausen [:philikon]]

(In reply to Philipp von Weitershausen [:philikon] from comment #10)
> You don't necessarily have to change `rilMessageType`. Just use
> 
>   switch "setCallWaiting":

I meant s/case/switch of course :)

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Philipp von Weitershausen [:philikon] from comment #11)
> (In reply to Philipp von Weitershausen [:philikon] from comment #10)
> > You don't necessarily have to change `rilMessageType`. Just use
> > 
> >   switch "setCallWaiting":
> 
> I meant s/case/switch of course :)
Ha, I got it!

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

gaia pull request: https://github.com/mozilla-b2g/gaia/pull/4433

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch (v5): get/set ril.callwaiting.enabled. r=philikon

Comment 10 addressed. r=philikon

Comment 15

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c1d23fe3275

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c1d23fe3275