[Azure] DrawTargetD2D::CreateBrushForPattern should be able to deal with surfaces from other Azure backends

RESOLVED FIXED in mozilla17

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: nrc, Assigned: nrc)

Tracking

15 Branch
mozilla17
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Assignee

Description

7 years ago
Crashes with a null pointer exception in D2D code.
Assignee

Updated

7 years ago
OS: All → Windows 7
Assignee

Comment 1

7 years ago
Posted file test case
You need to have D3D layers and D2D enabled, then prefer the Cairo Azure backend, then load the test case (you'll need some local file called hippo.jpg, or change to some other image name, doesn't seem to work with remote images though).

Expected: a 100x100 part of the image at the top left, and the whole image on the right

Actual result: crashes
Assignee

Comment 2

7 years ago
Posted patch patchSplinter Review
Attachment #653659 - Flags: review?(bas.schouten)
Comment on attachment 653659 [details] [diff] [review]
patch

Looks fine to me, keep in mind this is not encouraged practice :).
Attachment #653659 - Flags: review?(bas.schouten) → review+
Assignee

Comment 4

7 years ago
(In reply to Bas Schouten (:bas) from comment #3)
> Comment on attachment 653659 [details] [diff] [review]
> patch
> 
> Looks fine to me, keep in mind this is not encouraged practice :).

Having different backends for content and canvas? Or passing surfaces from one backend to another? Because the latter will always happen if we allow the former.
https://hg.mozilla.org/mozilla-central/rev/ca3a3ff0af73
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.