Closed Bug 784264 Opened 12 years ago Closed 12 years ago

high cpu and heap-unclassified

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: glob, Unassigned)

References

(
URL
)

Details

one of the updates within the last week (between 2012-08-17 and 2012-08-20) has resulted in my browser consuming high cpu and heap-unclassified after startup.  i'm currently using 17.0a1 (2012-08-20) on osx.

currently it's using 100% cpu and heap-unclassified is 36% and rising.  i've seen it hit more than 60% before (it didn't stop rising, i restarted nightly).

profile: http://people.mozilla.com/~bgirard/cleopatra/?report=1badaed9d656773b0d770efc007cc7a14ecf1aad

1,513.25 MB (100.0%) -- explicit
├────544.92 MB (36.01%) ── heap-unclassified
├────426.52 MB (28.19%) ++ js-non-window
├────355.33 MB (23.48%) ++ window-objects
├─────96.72 MB (06.39%) ++ workers
├─────43.71 MB (02.89%) ── xpconnect
├─────24.26 MB (01.60%) ++ storage
└─────21.78 MB (01.44%) ++ (10 tiny)
i suspect this is related to the copy-shorturl add-on (https://github.com/fwenzel/copy-shorturl).  with this disabled i'm unable to reproduce.

the extension is very simple, so it may be related to the version of jetpack it's built with (1.6.1).
Product: Firefox → Add-on SDK
Version: Trunk → unspecified
Alex, Jeff: was this addon one of the addons your script can repack?
No, as it is using low level APIs.
But as it is using 1.6.1 it shouldn't be leaking a lot?
1.6.1 was the release where we fixed context-menu leak, right?
If you want me to repackage that add-on with the latest version of the SDK (which is which version?) then I am happy to do that.
1.9's the official release. 

If that doesn't help, it might be interesting to see if 1.11-dev from Github's master branch would help. You wouldn't be able to use it on AMO, but it'd be useful for troubleshooting.
In fact, I did just that:

<https://addons.mozilla.org/en-US/firefox/addon/copy-shorturl/versions/?page=1#version-1.5>

If anyone has the power to do so, feel free to review (and thus release) this version.
I was getting hit by this pretty hard, seems to have started in a Nightly from late last week/weekend...

I've been trying to catch it in the Gecko profiler, but as luck would happen it hasn't happened in the last day. :| (Well, I caught a bit of it once, but wasn't able to look into it because it stopped. This is what I saw in the profiler: http://cl.ly/image/1K331p2q0H3n)
Updating it seems to have worked.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
how do we determine what other addons were impacted by the change in firefox, and get them updated?
You need to log in before you can comment on or make changes to this bug.