bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Replace body[dir="rtl"] with :dir(rtl)

RESOLVED FIXED in mozilla17

Status

()

Toolkit
Themes
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: Ekanan Ketunuti)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=dao][lang=css])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Bug 562169 implemented the :dir function. We should use that instead of the body[dir="rtl"] selector.

http://mxr.mozilla.org/mozilla-central/search?string=body[dir%3D&find=\.css%24&filter=toolkit/
(Assignee)

Updated

6 years ago
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 653703 [details] [diff] [review]
patch
Attachment #653703 - Flags: review?(dao)
(Reporter)

Comment 2

6 years ago
Comment on attachment 653703 [details] [diff] [review]
patch

Your new selectors are unnecessarily inefficient, e.g. ":dir(rtl) #errorPageContainer" should just be "#errorPageContainer:dir(rtl)".
Attachment #653703 - Flags: review?(dao) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 653710 [details] [diff] [review]
patch2
Attachment #653703 - Attachment is obsolete: true
Attachment #653710 - Flags: review?(dao)
(Reporter)

Comment 4

6 years ago
Comment on attachment 653710 [details] [diff] [review]
patch2

Thanks!
Attachment #653710 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/eb4392d9bc48
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.