Closed Bug 784297 Opened 9 years ago Closed 9 years ago

Thumbnail for about:home is out of date/incorrect

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox15 affected, firefox16 affected, firefox17 affected, firefox20 verified)

VERIFIED FIXED
Firefox 20
Tracking Status
firefox15 --- affected
firefox16 --- affected
firefox17 --- affected
firefox20 --- verified

People

(Reporter: pretzer, Assigned: pretzer)

Details

Attachments

(3 files, 1 obsolete file)

Attached image Screenshot of the issue
Bug 715928 added a static thumbnail to be shown when about:home is open in the tabs list, because taking screenshots was not possible on about:home. The layout of about:home has since been overhauled leaving the thumbnail out of date. 
In addition, even if it is updated to show the new styling, the thumbnail doesn't apply to the different layouts of landscape mode and tablets because the thumbnail always just shows the phone portrait mode.

Possible solutions:

1) Update the phone portrait thumbnail (and live with the fact that other layouts do not show a perfectly correct thumbnail)

2) Include a thumbnail for all every layout (probably not wanted, due to increased app size)

3) Use a generic icon/thumbnail that applies to all layouts (e.g. a big house icon)

4) Enable screenshots on about:home (might not be possible)
I think it's easiest to just go with option 1) for now, since does not seem to be a big deal for anyone at the moment. Anything else could happen in a follow-up. Any other opinions?
Therefore I created the new thumbnails with the same width/height as the old ones. They'd also save us 11,4 KB in size ;-)
Attached file The new tumbnails (obsolete) —
Ian, can you have a look at the thumbnails I created and check if they work for now? Or do you prefer another solution?
Flags: needinfo?(ibarlow)
Hey thanks for taking a look at this Peter, these look great.

One thing -- I had been meaning to blank out the text, since on larger resolutions it's actually readable and would look incorrect for other locales. 

Would you mind trying one where you remove the "Top Sites" text and thumbnail titles? Keep all the backgrounds in place, just remove the titles.
Flags: needinfo?(ibarlow)
Like this?
Yep, thanks Peter.
Attachment #680569 - Attachment is obsolete: true
Attached patch patchSplinter Review
I always wanted to submit a patch to Firefox, so here is my first try! \o/
No code change, I just swapped the three thumbnails.
Assignee: nobody → peter.retzer
Status: NEW → ASSIGNED
Attachment #681450 - Flags: review?(sriram)
Comment on attachment 681450 [details] [diff] [review]
patch

Review of attachment 681450 [details] [diff] [review]:
-----------------------------------------------------------------

Oops. Sorry for getting late at this. This looks great :) :)
Attachment #681450 - Flags: review?(sriram) → review+
Thanks, Sriram! :-)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a7125bc00ed9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
The about:home thumbnail was updated on the latest Nightly. Closing bug as verified fixed on:

Firefox 20.0a1 (2012-12-06)
Device: Galaxy Tab2 7"
OS: Android 4.0.3
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.