Closed Bug 78441 Opened 24 years ago Closed 24 years ago

font in source view is huge

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED DUPLICATE of bug 79277
Milestone:
mozilla0.9.1

People

(Reporter: bugzilla, Assigned: cmanske)

References

Details

(Keywords: platform-parity, regression)

Attachments

(1 file)

Simplify CSS to just use "font-family : -moz-fixed"
2.07 KB, patch
Details | Diff | Splinter Review
i'm using 2001.05.01.08 linux mozilla bits. the monospace font in the source view of editor is now quite large. however, the fontsize of the monospace font in a plaintext mail compose --as well as textfields of forms in the browser window-- is actually of reasonable size [not huge].
this is a regression.
Keywords: mozilla0.9.1, regression
I don't see a huge font in my debug build from today, in fact, I don't see the monospace font in Windows! Is this only on Linux? Could you please check for size and "monospace" on all platforms. Thanks. Before the "new" Modern font, the "font-size : larger" I used didn't seem to do anything (the monospace font was *very* small then.)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Did you try 'font-family: -moz-fixed'. This seems to give a reasonable default because it is tweaked internally (see the settings that viewsource.css uses for example).
See the fix for bug 76191. I used this for all platforms. font-family : -moz-fixed, monospace; font-size : larger;
Depends on: 76191
Hewitt: anything change in new skins checkin that could have caused this? My recent change for bug 76191 is there; any other "-moz-fixed" not working? Sarah: Please test all platforms.
Charles, see my comments from "2001-04-30 22:27" on bug 76531. It seems that at least on linux -moz-fixed gets ignored in "font-family: -moz-fixed, monospace;" Removing the "monospace" part makes it work right. This feels like a bug in the style system, but apparently handling of -moz-fixed is kinda wacky...
Not being able to handle "-moz-fixed, monospace" sounds like a real bug to me; that is standard CSS syntax. Did you file a bug on that issue (Linux-only, correct)?
Bug 78517 filed. I don't know whether this is Linux-only. I don't have anything else to test on (well, Solaris and Irix, but...) Easy way to test. With the "-moz-fixed, monospace" in your stylesheet, pick a very small font for monospace in preferences. If the text in question is shown in the really small font, then things are working correctly. Otherwise you're seeing bug 78517. If people could test that on Windows/Mac and comment on 78517, that would be great.
Ok, we don't have time to mess around. I'll change the CSS to simply use: #content-source, #doctype-text { font-family : -moz-fixed; } Note that I'm dropping the previously-added font-size : larger; as the user's pref includes setting the size, so this seems the correct thing to do.
Whiteboard: FIX IN HAND need r=, sr=
Charley said in bug 76191 that this bug contained the patch to fix the problem in that bug (using fixed-width fonts in plaintext compose), but the patch to this bug does not fix that problem -- I still see variable-width fonts in the plaintext compose window after applying this patch and rebuilding in mozilla/themes.
I'm having trouble pulling today, but yesterday (after the "new" modern landing), I also *didn'* see the fixed width font in Windows. I think something was busted with new theme :( I believe this patch is the right one, though, to try to get fixed width. Hewitt?
Applied and tested the patch on Win2K and it worked as expected. Before the patch, clicking '<HTML> source' was rendering in a variable-size font. After the patch, it renders in a fixed-size font.
Looks ok on Windows now. What about Mac and Linux?
Reviews done, just need final testing to mark fixed.
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND
Fixes things for me on Linux as well...
In my Linux build from today, I still see a huge font in the html source tab.
The font size should be whatever is set in your user prefs for Appearance | Fonts | "Fixed-width fonts". Try adjusting that.
The font size in the prefs isn't being respected in the multiline textfield (i.e., HTML Source window), but that's a separate issue. (I will file a new bug.) Marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Please resolve this bug when the new bug has been filed (I don't see one right now); reopening for now
Status: RESOLVED → REOPENED
Keywords: pp
Resolution: FIXED → ---
Bug 79227 has been filed on the issue that font size is not set correctly. It seems most correct to dup this bug to that one, since this bug did address the size issue to begin with. *** This bug has been marked as a duplicate of 79277 ***
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → DUPLICATE
Whiteboard: FIX IN HAND
verified in 5/7 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: