As a first case for [infallible] (bug 780970), we can add it on some nsIDocShell attributes. I'd rather not land bug 780970 without using it somewhere.
nsILoadContext.usePrivateBrowsing could use it.
There's a fishy-looking change in nsFrameLoader::Swap: We used to check isContentBoundary, isApp, and isBrowser. But actually we only need to check isApp and isBrowser, because isContentBoundary == isApp || isBrowser.
Attachment #653989 - Flags: review?(bzbarsky)
Attachment #653988 - Flags: review?(bzbarsky)
Assignee: nobody → justin.lebar+bug
Comment on attachment 653988 [details] [diff] [review] Part 1, v1: Make some nsIDocShell attributes infallible. r=me
Attachment #653988 - Flags: review?(bzbarsky) → review+
Comment on attachment 653989 [details] [diff] [review] Part 2, v1: Use new infallible nsIDocShell methods. r=me
Attachment #653989 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.