Switch to [infallible] for some nsIDocShell attributes

RESOLVED FIXED in mozilla17

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
As a first case for [infallible] (bug 780970), we can add it on some nsIDocShell attributes.

I'd rather not land bug 780970 without using it somewhere.

Comment 1

5 years ago
nsILoadContext.usePrivateBrowsing could use it.
(Assignee)

Comment 2

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=7ff8a2520474
(Assignee)

Comment 3

5 years ago
Created attachment 653988 [details] [diff] [review]
Part 1, v1: Make some nsIDocShell attributes infallible.
(Assignee)

Comment 4

5 years ago
Created attachment 653989 [details] [diff] [review]
Part 2, v1: Use new infallible nsIDocShell methods.

There's a fishy-looking change in nsFrameLoader::Swap: We used to check isContentBoundary, isApp, and isBrowser.  But actually we only need to check isApp and isBrowser, because isContentBoundary == isApp || isBrowser.
Attachment #653989 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Attachment #653988 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Assignee: nobody → justin.lebar+bug
Comment on attachment 653988 [details] [diff] [review]
Part 1, v1: Make some nsIDocShell attributes infallible.

r=me
Attachment #653988 - Flags: review?(bzbarsky) → review+
Comment on attachment 653989 [details] [diff] [review]
Part 2, v1: Use new infallible nsIDocShell methods.

r=me
Attachment #653989 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/bd0bf4b676da
https://hg.mozilla.org/mozilla-central/rev/eb81ebe55d99
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.