Closed
Bug 784436
Opened 13 years ago
Closed 13 years ago
Switch to [infallible] for some nsIDocShell attributes
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
Attachments
(2 files)
|
5.53 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
10.72 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
As a first case for [infallible] (bug 780970), we can add it on some nsIDocShell attributes.
I'd rather not land bug 780970 without using it somewhere.
|
||
Comment 1•13 years ago
|
||
nsILoadContext.usePrivateBrowsing could use it.
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Comment 4•13 years ago
|
||
There's a fishy-looking change in nsFrameLoader::Swap: We used to check isContentBoundary, isApp, and isBrowser. But actually we only need to check isApp and isBrowser, because isContentBoundary == isApp || isBrowser.
Attachment #653989 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #653988 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → justin.lebar+bug
|
||
Comment 5•13 years ago
|
||
Comment on attachment 653988 [details] [diff] [review]
Part 1, v1: Make some nsIDocShell attributes infallible.
r=me
Attachment #653988 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 653989 [details] [diff] [review]
Part 2, v1: Use new infallible nsIDocShell methods.
r=me
Attachment #653989 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bd0bf4b676da
https://hg.mozilla.org/mozilla-central/rev/eb81ebe55d99
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•