Closed Bug 784584 Opened 9 years ago Closed 7 years ago

Mozbase & Addon-SDK can't co-exist

Categories

(Add-on SDK Graveyard :: General, defect, P3)

x86
Linux

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: arky, Unassigned)

References

Details

You can't have mozbase and addon-sdk installed on the same computer. You will get the following error when you run cfx.

Your sample add-on is now ready.
Do "cfx test" to test it and "cfx run" to try it.  Have fun!
(addon-sdk)arky@Arky-Think:/tmp/foo$ cfx test
Traceback (most recent call last):
  File "/home/arky/src/addon-sdk/bin/cfx", line 33, in <module>
    cuddlefish.run()
  File "/home/arky/src/addon-sdk/python-lib/cuddlefish/__init__.py",
line 778, in run
    from cuddlefish.runner import run_app
  File "/home/arky/src/addon-sdk/python-lib/cuddlefish/runner.py",
line 98, in <module>
    class FennecProfile(mozrunner.Profile):
AttributeError: 'module' object has no attribute 'Profile'
Summary: Mozbase & Addon-SDK can't co-exit → Mozbase & Addon-SDK can't co-exist
Jeff, is this happening for you?
Whiteboard: [triage:followup]
This probably would happened to me if i used these two in the same python package space and has happened in the past.  I practice I avoid this.  If there is no interest in getting addon-sdk on modern mozrunner (etc) in a way that allows upstream fixes (e.g. subrepos or mirroring), I would suggest the solution to this problem is to change the addon-sdk to prefix or otherwise rename mozrunner to e.g. jetpackrunner, etc: http://hg.mozilla.org/projects/addon-sdk/file/46899759e146/python-lib/mozrunner

I would prefer a solution where mozrunner, etc, was kept up to date with active development.  But if this isn't a case, I believe a rename is the easiest solution.  You could also ensure that the addon-sdk python path usurps the (e.g.) system python path, but I would guess this would cause more problems than it is worth.
CCing Mossop and Gozala to figure out where we want to go from here.
Sounds like prefixing is the simplest course here, though I wouldn't object to seeing us updated to mozrunner proper. However I don't think we have the resources within the team to do either right now.
Priority: -- → P3
Whiteboard: [triage:followup]
We can close this when bug 915376 is done I suspect.
Sorry we won't be releasing any new versions of cfx, jpm is the replacement https://www.npmjs.com/package/jpm
Blocks: cfx.py
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.