78460 - Spelling Dictionary dialog resizes after adding new word when user's dictionary list is empty

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Charles Manske]

This bug is really an XPFE problem (bug 74467), which won't be fixed in time,
so there is a JS workaround (to be attached), otherwise, this dialog is not
useable the first time (i.e., no existing user dictionary file: "custom.dic")

Comment 1

[Charles Manske]

Adding depency on the real problem, bug 74467.

Comment 2

[Charles Manske]

Attachment: Fixes resizing of dialog. Also cleans up JS by using the "dialog" JS object that all other dialogs use.

Comment 3

[Charles Manske]

Sorry to add so much extra changes, but this dialog was in need of cleanup since
it didn't use the common pattern of attaching XUL elements to a "dialog" object.
This are the lines that fix for the resize problem:
+  var haveList = false;
+
   // Get words until an empty string is returned
   do {
     word = spellChecker.GetPersonalDictionaryWord();
     if (word != "")
-      AppendStringToTreelist(DictionaryList, word);
-
+    {
+      AppendStringToTreelist(dialog.DictionaryList, word);
+      haveList = true;
+    }
   } while (word != "");
+
+  //BUG 74467: If list is empty, tree doesn't layout to full height correctly
+  //     (ignores "rows" attribute)
+  if (!haveList)
+    AppendStringToTreelist(dialog.DictionaryList, " ");

Comment 4

[kinmoz]

sr=[e-mail] with the changes we discussed.

Comment 5

[Charles Manske]

Attachment: Updated patch: more cleanup in JS, use regexp to search for URI patterns

Comment 6

[Charles Manske]

What the ??? Last patch is bogus. Shouln't include EdDialog.js change -- that
was part of fix for bug 77930! The EdDictionary changes in 5/04 patch are the
correct ones I checked in.

Comment 7

[sujay]

verified in 6/6 build.