784682 - Penalize nodes with "hidden" class or id in Readability.js

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Lucas Rocha (:lucasr)]

Attachment: Penalize nodes marked as "hidden"

Nodes explicitly marked as hidden somehow should be penalized in the scoring algorithm. This patch fixes the duplicate content when viewing sites like http://online.wsj.com/article_email/SB114739560986950892-lMyQjAxMDE2NDE3MjMxOTI1Wj.html.

This patch is not specific to this page but should apply safely to any other page following a similar pattern.

Comment 1

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c3457b601d8

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 654210 [details] [diff] [review]
Penalize nodes marked as "hidden"

[Approval Request Comment]
User impact if declined: Reader might show duplicate content on pages like online.wsj.com which have a hidden copy of the article.
Testing completed (on m-c, etc.): Tons of local tests, no regressions.
Risk to taking this patch (and alternatives if risky): Low, will only affect the DIVs marked with "hidden" class or id.
String or UUID changes made by this patch: None.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c3457b601d8

Comment 4

[Lucas Rocha (:lucasr)]

Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/dbb77e74c67b

Comment 5

[Andreea Pod]

No duplicate content on http://online.wsj.com/article_email/SB114739560986950892-lMyQjAxMDE2NDE3MjMxOTI1Wj.html, marking this as verified fixed.

Build: Firefox 17.0a1 (2012-08-27)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1