Closed Bug 784682 Opened 8 years ago Closed 8 years ago

Penalize nodes with "hidden" class or id in Readability.js

Categories

(Firefox for Android :: Reader View, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 17
Tracking Status
firefox16 --- verified
firefox17 --- verified

People

(Reporter: lucasr, Assigned: lucasr)

Details

Attachments

(1 file)

Nodes explicitly marked as hidden somehow should be penalized in the scoring algorithm. This patch fixes the duplicate content when viewing sites like http://online.wsj.com/article_email/SB114739560986950892-lMyQjAxMDE2NDE3MjMxOTI1Wj.html.

This patch is not specific to this page but should apply safely to any other page following a similar pattern.
Attachment #654210 - Flags: review?(bnicholson)
Attachment #654210 - Flags: review?(bnicholson) → review+
Comment on attachment 654210 [details] [diff] [review]
Penalize nodes marked as "hidden"

[Approval Request Comment]
User impact if declined: Reader might show duplicate content on pages like online.wsj.com which have a hidden copy of the article.
Testing completed (on m-c, etc.): Tons of local tests, no regressions.
Risk to taking this patch (and alternatives if risky): Low, will only affect the DIVs marked with "hidden" class or id.
String or UUID changes made by this patch: None.
Attachment #654210 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6c3457b601d8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Attachment #654210 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
No duplicate content on http://online.wsj.com/article_email/SB114739560986950892-lMyQjAxMDE2NDE3MjMxOTI1Wj.html, marking this as verified fixed.

Build: Firefox 17.0a1 (2012-08-27)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.