784684 - Sending event for volume state changed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

Attachment: Sending event.

Volume state change currently cannot be caught by statusbar for example. The small attached patch takes the event sent from the underlying volume service and make it available.

Comment 1

[Dave Hylands [:dhylands]]

Cool. 

So the only concern I have is related to OOP stuff. The volume-state-changed messages are only sent on the ParentProcess. Does the event get sent to OOP windows?

Comment 2

[:gerard-majax]

I have no idea, it's clearly out of my scope of knowledge. All I can tell you is that the matching pull request on gaia [https://github.com/mozilla-b2g/gaia/pull/3709] makes the USB Mass Storage icon visible in the status bar, so the event gets correctly caught by the statusbar.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 654217 [details] [diff] [review]
Sending event.

(In reply to Dave Hylands [:dhylands] from comment #1)
> Cool. 
> 
> So the only concern I have is related to OOP stuff. The volume-state-changed
> messages are only sent on the ParentProcess. Does the event get sent to OOP
> windows?

I don't think we are going to run System app OOP so that shouldn't be a concern. (what would disable all the mozChromeEvent dispatching in shell.js)

Can you r+ this pull request? I cannot find where the "Shared" state string come from nor what's the state actually means.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Or, @vingtetun can r+ this pull request ...

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Also, this bug is being filed as duplicate of bug 774578. The discussion and blocking status is there but the patch is here, so I am not sure which one to close...

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 654217 [details] [diff] [review]
Sending event.

Review of attachment 654217 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/shell.js
@@ +692,5 @@
> +    shell.sendChromeEvent({
> +      type: 'volume-state-changed',
> +      active: (aData == "Shared")
> +    });
> +}, "volume-state-changed", false);

Nit: use single quotes everywhere in this file (even if it's ugly...)

Comment 7

[Dave Hylands [:dhylands]]

> Can you r+ this pull request? I cannot find where the "Shared" state string
> come from nor what's the state actually means.

I'm not really a good person for reviewing JS stuff. In answer to your question, the Shared starts off in vold, as a number which is defined here:
https://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/nsIVolume.idl#20

and then gets converted into a string here:
https://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/nsVolume.cpp#26

Shared means that the sdcard is currently being shared with the PC.

Comment 8

[:gerard-majax]

Attachment: Update.

Addressing single-quotes issue.

Comment 9

[:gerard-majax]

ping?

Comment 10

[Dave Hylands [:dhylands]]

So if you don't have privilege to land a bug yourself, you should add a checkin-needed to the keywords.

When you create a new patch, you should obsolete the old one so it's obvious which patch needs to be landed.

I can go ahead and land this for you.

Comment 11

[Philipp von Weitershausen [:philikon]]

(In reply to Dave Hylands [:dhylands] from comment #10)
> I can go ahead and land this for you.

I got it. Already landing bug 782289 for Alexandre.

Comment 12

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/302dc2286ce0

(Patch was missing author info, so I accidentally pushed this under my info. Sorry.)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/302dc2286ce0

Comment 15

[Andrew Overholt [:overholt]]

Seems like something we wouldn't want to regress.