Closed Bug 784691 Opened 7 years ago Closed 7 years ago

Upgrade clang to r162360

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: espindola, Assigned: espindola)

References

Details

Attachments

(3 files)

This upgrade will include
* A fix to a visibility bug noticed when building firefox with libc++ (llvm.org/pr13662)
* asan improvements for os x.
* a bit of performance work.
I suspect you mean for this to be in Release Engineering.
Yes, thanks.
Assignee: respindola → nobody
Component: MozillaBuild → Release Engineering
Assignee: nobody → respindola
I have just copied the files with:

ssh respindola@people.mozilla.org -L 1500:relengweb1.dmz.scl3.mozilla.com:22
scp -P 1500 * respindola@localhost:/var/www/html/runtime-binaries/tooltool/sha512/
ssh -p 1500 respindola@localhost
cd /var/www/html/runtime-binaries/tooltool/sha512/
chmod 444 ...
In the next update I will try to merge build-clang.py and create-manifest.py, this is a step in that direction.
Attachment #654467 - Flags: review?(rail)
Whiteboard: [Leave open]
I have removed

browser/config/tooltool-manifests/macosx32/clang.manifest
and
browser/config/tooltool-manifests/macosx64/clang.manifest

since they are redundant with the releng manifest now that OS X has switched.
Attachment #654488 - Flags: review?(rail)
Attachment #654467 - Flags: review?(rail) → review+
Attachment #654471 - Flags: review?(rail) → review+
Attachment #654488 - Flags: review?(rail) → review+
Depends on: 793643
The results I got with diff-talos were:

dromaeo_css
MacOSX 10.6 (rev4)                | (2854.75909091, 16.9361015385) -> (2760.39916667, 15.0210672414) 1.0342x worse
MacOSX 10.7                       | (2802.51916667, 22.2119552504) -> (2731.13333333, 18.5358431148) 1.0261x worse

kraken
MacOSX 10.8                       | (2150.70909091, 2.0410165778)  -> (2168.07272727, 4.95538710857) 1.0081x worse

tdhtmlr_nochrome_paint
MacOSX 10.6 (rev4)                | (412.080090909, 0.684712591228) -> (410.255769231, 0.966515525145) 1.0044x better

I went ahead with the upgrade because:
* These are compiler changes. Since we run the same binary on 10.6, 10.7 and 10.8, any "real" regression is expected to show up on all of them.
* I could not reproduce it locally.
* This upgrade is blocking more important ones: 797564, 797525 and specially 793109.
* On the last upgrade the regressions that I was seeing comparing two try revisions did not materialize on m-i (no email).
* This is extremely easy to revert if the regressions turn out to be real.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Leave open]
Duplicate of this bug: 798293
Depends on: 799572
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.