784697 - Do not force mobile width for /developers/ and .../statistics/

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

Very related to /developers header brokenness (bug 783445), if we're going to be forcing the mobile-width layout across the site then /developers/ and .../statistics/ should be exempt.

This is what it currently looks like the forced width: http://f.cl.ly/items/352E3P1M0Q0C0d113M2L/Screen%20shot%202012-08-22%20at%209.05.19%20AM.png

These are the pages that come to mind:
https://marketplace-dev.allizom.org/developers/
https://marketplace-dev.allizom.org/app/evernote-web/statistics/

Comment 1

[krupa raj[:krupa]]

Also,
https://marketplace-dev.allizom.org/app/breakit/activity/

Comment 2

[Fred Wenzel [:wenzel]]

This is a high priority for us; the devhub is largely unusable right now.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Fred Wenzel [:wenzel] from comment #2)
> This is a high priority for us; the devhub is largely unusable right now.

https://github.com/mozilla/zamboni/commit/a518a28adc5

Potch fixed this a few minutes ago for https://marketplace-dev.allizom.org/developers/

It's looking much better: http://f.cl.ly/items/061p392t343j1t00161U/Screen%20shot%202012-08-22%20at%2010.50.44%20AM.png

We should keep the bug open for /statistics/ and /activity/

Comment 4

[Fred Wenzel [:wenzel]]

Thanks a ton. This makes working on the devhub a *lot* easier. <3

Comment 5

[Potch [:potch]]

Maria, are the statistics pages part of what we would call the "consumer ui", aka the app-ified pages? If they're not, I'd like to disconnect their styles from those of what I call the app the same way I did for the developer pages. We can chat in person if that made no sense whatsoever :)

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to Potch [:potch] from comment #5)
> Maria, are the statistics pages part of what we would call the "consumer
> ui", aka the app-ified pages?

I'm not Maria, but we've chatted about this. And yeah maybe one day the stats pages will have mobile-optimized designs but that day's not near. So, they're not app-y pages, correct.

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #6)
> I'm not Maria

I just now noticed!

Comment 8

[Potch [:potch]]

> I'm not Maria, but we've chatted about this. And yeah maybe one day the
> stats pages will have mobile-optimized designs but that day's not near. So,
> they're not app-y pages, correct.

I'm going to have them pull from a developer css bundle then instead of mkt/consumer. Any opinions on ecosystem vs devhub?

Comment 9

[Christopher Van Wiemeersch [:cvan]]

(In reply to Potch [:potch] from comment #8)
> > I'm not Maria, but we've chatted about this. And yeah maybe one day the
> > stats pages will have mobile-optimized designs but that day's not near. So,
> > they're not app-y pages, correct.
> 
> I'm going to have them pull from a developer css bundle then instead of
> mkt/consumer. Any opinions on ecosystem vs devhub?

It's been a dream of mine to have the new ecosystem pages (e.g., /developers/) use the same Developer Hub styles (mkt/devreg). If you'd like to sit down and knock this out together, I'm totes down. It'll help us in the long run I think.

Comment 10

[Maria Sandberg [:mushi]]

Glad to hear we are all in line on who I am and am not :) 
The stats should live with the developer stuff yes, totes agree. 

Fred - does DevHub have opinions on what pages should look like they belong together? I know your team have been thinking about similar things regarding DevHub / MDN.

Comment 11

[Fred Wenzel [:wenzel]]

(In reply to Maria Sandberg [:mushi] from comment #10)
> Fred - does DevHub have opinions on what pages should look like they belong
> together? I know your team have been thinking about similar things regarding
> DevHub / MDN.

I think the devhub should have a consistent look and feel with the submission pages and other developer-facing parts of the marketplace. Do you agree?

To what extent (completely) differing styles between MDN and devhub matter in this context I haven't formed an opinion on but I think we should discuss this in the context of an improved IA that defines the relationship between devhub and MDN better.

Comment 12

[Maria Sandberg [:mushi]]

(In reply to Fred Wenzel [:wenzel] from comment #11)
> I think the devhub should have a consistent look and feel with the
> submission pages and other developer-facing parts of the marketplace. Do you
> agree?
Yes, completely agreee. 

> To what extent (completely) differing styles between MDN and devhub matter
> in this context I haven't formed an opinion on but I think we should discuss
> this in the context of an improved IA that defines the relationship between
> devhub and MDN better.
Okay, sounds good.

Comment 13

[Potch [:potch]]

https://github.com/mozilla/zamboni/commit/7e43246

Comment 14

[krupa raj[:krupa]]

https://marketplace-dev.allizom.org/app/breakit/statistics/?last=30 and https://marketplace-dev.allizom.org/developers/ look fixed.

Humor me and fix https://marketplace-dev.allizom.org/app/breakit/activity/ as well?

Comment 15

[Potch [:potch]]

https://github.com/mozilla/zamboni/commit/84ba3a2 

fixed activity by moving it under the Lookup Tool. We might want a code quality bug to move the views, etc into the tool as well.