Closed
Bug 784701
Opened 13 years ago
Closed 12 years ago
Remove WebIDL userdata
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: khuey, Assigned: khuey)
Details
Attachments
(1 file, 1 obsolete file)
4.73 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
It only has one use, and it's kind of ugly, so lets ditch it.
Attachment #654234 -
Flags: review?(justin.lebar+bug)
Comment 1•13 years ago
|
||
> # If we're concrete, we need to crawl our ancestor interfaces and mark
> # them as having a concrete descendant.
> self.concrete = desc.get('concrete', True)
> if self.concrete:
> iface = self.interface
> while iface:
>- iface.setUserData('hasConcreteDescendant', True)
>+ if iface.isExternal():
>+ break
It's not clear to me why we should stop the first external interface in the parent chain.
>+ iface.setHasConcreteDescendant(True)
iface.hasConcreteDescendent = True would be more Pythonic, I think. You could
always make hasConcreteDescendent a property at some point in the future, if
you wanted to take some action when the value was set.
Updated•13 years ago
|
Attachment #654234 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Comment 2•13 years ago
|
||
You can't have an external interface with a real interface parent, afaik.
hasConcreteDescendant is more pythonic, but elsewhere we've used the setFoo stuff.
Comment 3•13 years ago
|
||
> but elsewhere we've used the setFoo stuff.
It's only setIsConsequentialInterfaceOf, and setCallback (which should be called setIsCallback), afaict. What if I volunteered to fix those two?
![]() |
||
Comment 4•13 years ago
|
||
Comment on attachment 654234 [details] [diff] [review]
Patch
If a concrete interface inherits from an external interface, don't we just want to throw?
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Justin Lebar [:jlebar] from comment #3)
> > but elsewhere we've used the setFoo stuff.
>
> It's only setIsConsequentialInterfaceOf, and setCallback (which should be
> called setIsCallback), afaict. What if I volunteered to fix those two?
I'd be fine with that. I'm mostly interested in consistency.
Comment 6•13 years ago
|
||
Actually, seIsConsequentialInterfaceOf(x) is not the same type of thing -- it's basically self.myConsequentialInterfaces.append(x). So it's just the isCallback guy.
Comment 7•13 years ago
|
||
And if we made isCallback a property, we'd have to change isDictionary, isInterface...I guess that's a job for later. :)
Assignee | ||
Comment 8•13 years ago
|
||
Attachment #654234 -
Attachment is obsolete: true
Attachment #654247 -
Flags: review+
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to Boris Zbarsky (:bz) [In and out Aug 1 - 10, out Aug 11-20] from comment #4)
> Comment on attachment 654234 [details] [diff] [review]
> Patch
>
> If a concrete interface inherits from an external interface, don't we just
> want to throw?
Done.
Assignee | ||
Comment 10•12 years ago
|
||
We're using this for things now. May want to revisit it later but it's not important.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INCOMPLETE
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•