784728 - BatteryObserver is RefCounted, but pointer is managed manually

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Marshall Culpepper [:marshall_law]]

I'm currently seeing this on the ARM emulator in debug builds, when exiting the process to apply a new update.

It looks like GonkHal.cpp tries to manually delete a BatteryObserver pointer, when BatteryObserver extends RefCounted. Relevant lines of code:

http://dxr.mozilla.org/mozilla-central/hal/gonk/GonkHal.cpp.html#280
http://dxr.mozilla.org/mozilla-central/mfbt/RefPtr.h.html#50

Comment 1

[Marshall Culpepper [:marshall_law]]

Attachment: make sBatteryObserver a RefPtr

Comment 2

[Mounir Lamouri (:mounir)]

You might want to use StaticRefPtr, see bug 772987. And ask jlebar to review the patch.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Egads.

Comment 4

[Marshall Culpepper [:marshall_law]]

Attachment: make sBatteryObserver a StaticRefPtr - v1

Updated patch to use StaticRefPtr

Comment 5

[Justin Lebar (not reading bugmail)]

Comment on attachment 655487 [details] [diff] [review]
make sBatteryObserver a StaticRefPtr - v1

r=me.  Please push to try and let me know if and when you'd like me to push this patch to m-i for you.

Comment 6

[Marshall Culpepper [:marshall_law]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c05251c5a7e3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c05251c5a7e3