Closed
Bug 784744
Opened 12 years ago
Closed 12 years ago
increase the number of update verify chunks
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(2 files)
484 bytes,
patch
|
rail
:
review+
nthomas
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
4.66 KB,
patch
|
rail
:
review+
nthomas
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
When update verify was first chunked it was split into 15 chunks, which ended up being too many. Now it's 3 chunks which worked well for awhile, but now that we're doing full checks on all previous versions as well as multiple partials, it's probably time to increase it. For Firefox 15.0b6, one chunk took over 3h on Windows. I suggest we increase the chunking to 6 per platform, which is the same as l10n. Slave availability shouldn't be an issue since we use 64-bit windows build machines rather than 32-bit ones. ESR might not be able to fully parallalize on Windows as its still using 32-bit build machines, but there's almost no overhead to update verify, so it doesn't hurt if some of the chunks end up running on the same slaves.
Attachment #654302 -
Flags: review?(rail)
Attachment #654302 -
Flags: review?(nrthomas)
Comment 1•12 years ago
|
||
Comment on attachment 654302 [details] [diff] [review] change default ||ization to 6 Sounds good to me.
Attachment #654302 -
Flags: review?(rail) → review+
Assignee | ||
Comment 2•12 years ago
|
||
We can stop setting this in production configs if we use 6 chunks, too.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #654303 -
Flags: review?(rail)
Attachment #654303 -
Flags: review?(nrthomas)
Updated•12 years ago
|
Attachment #654303 -
Flags: review?(rail) → review+
Updated•12 years ago
|
Attachment #654303 -
Flags: review?(nrthomas) → review+
Comment 3•12 years ago
|
||
Comment on attachment 654302 [details] [diff] [review] change default ||ization to 6 Lets watch out for load on hg and stage/ftp from this. We might have to teach update verify to use hg share for the tools checkout (or there's the bug about having a perma-checkout of tools on each slave).
Attachment #654302 -
Flags: review?(nrthomas) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #654303 -
Flags: checked-in+
Assignee | ||
Updated•12 years ago
|
Attachment #654302 -
Flags: checked-in+
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Nick Thomas [:nthomas] from comment #3) > Comment on attachment 654302 [details] [diff] [review] > change default ||ization to 6 > > Lets watch out for load on hg and stage/ftp from this. We might have to > teach update verify to use hg share for the tools checkout (or there's the > bug about having a perma-checkout of tools on each slave). Yeah, absolutely. The jobs should auto-retry if they hit hg issues, so I'm going to land this for now and see what happens. If we have issues, I'll address them.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•