Closed Bug 784824 Opened 8 years ago Closed 7 years ago

support for remote debugging of b2g desktop builds

Categories

(DevTools :: Debugger, defect, P2)

x86
macOS
defect

Tracking

(firefox19 wontfix, firefox20 wontfix, b2g18 fixed)

RESOLVED FIXED
Firefox 21
Tracking Status
firefox19 --- wontfix
firefox20 --- wontfix
b2g18 --- fixed

People

(Reporter: dietrich, Assigned: past)

References

Details

(Whiteboard: [b2g])

Attachments

(1 file, 2 obsolete files)

This space reserved for what this actually means.
Assignee: nobody → past
Priority: -- → P2
Should this be closed now that bug 755661 has landed and remote debugging for B2G is working (AFAIK)?
Depends on: 799151
Depends on: 799153
We could leave it open for a while until we have done some polish around the debugger UX in Firefox OS. I'll use this bug for tracking the remaining work.
Whiteboard: [b2g]
Bug 799151 disabled remote debugging for B2G devices due to security/certification concerns. I'll post a patch to re-enable it for B2G desktop and the Firefox OS Simulator.
Status: NEW → ASSIGNED
Attached patch Patch v1 (obsolete) — Splinter Review
Attached patch Patch v2 (obsolete) — Splinter Review
Tagged dbg-browser-actors.js for preprocessing, tested Firefox and desktop-b2g. I'm having trouble testing on a device currently, because I'm stuck on the black screen with the Mozilla logo.
Attachment #700241 - Attachment is obsolete: true
Attachment #700273 - Flags: review?(fabrice)
Attachment #700273 - Flags: review?(fabrice) → review+
Verified that the device works as expected and landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e3c0acf418e9
Attached patch Final versionSplinter Review
The final version was rebased on top of m-i.
Attachment #700273 - Attachment is obsolete: true
Attachment #700470 - Flags: review+
Comment on attachment 700470 [details] [diff] [review]
Final version

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 799151
User impact if declined: the web console and the JS debugger won't work against b2g-desktop builds and the Firefox OS Simulator. Not sure if these products will ship releases off the b2g18 branch or not, though. If not, then we can skip this.
Testing completed: in m-i against Firefox desktop, b2g-desktop and on a Nexus S device
Risk to taking this patch (and alternatives if risky): this is devtools-related code that doesn't affect end users when not enabled
String or UUID changes made by this patch: none
Attachment #700470 - Flags: approval-mozilla-b2g18?
Attachment #700470 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
https://hg.mozilla.org/mozilla-central/rev/e3c0acf418e9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.