784838 - Failure restoring backup of binary during update tests

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[u279076]

I've noticed recently that the update tests sometimes fail with an error "Failure restoring backup of binary". This seems to happen between the direct and fallback update tests.

Here is sample output:
----------------------
Report document created at 'http://mozauto.iriscouch.com/mozmill-ondemand/d87d47fd1034f072b9bece6ee69516fd'
*** Restoring backup of binary (c:\users\mozauto\appdata\local\temp\tmphblq4m.binary_backup => c:\users\mozauto\appdata\local\temp\tmpwigwce.binary\)
*** Failure while restoring the backup of the binary.
[Error 145] The directory is not empty: 'c:\\users\\mozauto\\appdata\\local\\temp\\tmpwigwce.binary\\'
*** Removing repository 'c:\users\mozauto\appdata\local\temp\tmp_zhhx6.mozmill-tests'
Traceback (most recent call last):
  File "mozmill-automation/testrun_update.py", line 51, in <module>
    main()
  File "mozmill-automation/testrun_update.py", line 46, in main
    UpdateTestRun().run()
  File "c:\jenkins\workspace\ondemand_update\mozmill-automation\libs\testrun.py", line 942, in run
    TestRun.run(self)
  File "c:\jenkins\workspace\ondemand_update\mozmill-automation\libs\testrun.py", line 439, in run
    raise self.last_exception
WindowsError: [Error 145] The directory is not empty: 'c:\\users\\mozauto\\appdata\\local\\temp\\tmpwigwce.binary\\'
Build step 'Invoke XShell command' marked build as failure
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure
Sending email to: [e-mail]
Finished: FAILURE
-----------------

The actual testrun from this example can be seen here (server hidden):
http://server:port/view/@ondemand/job/ondemand_update/161/

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

I don't see a reason why we shouldn't ignore failures when removing a folder. If files can't be deleted we will probably fail in the following shutils.move() call but in such a case it should be a real misbehavior in Mozmill or Firefox.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 660028 [details] [diff] [review]
Patch v1

Review of attachment 660028 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove the .idea/testrunner.xml from the patch before pushing.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v2

Removed the project file from PyCharm which I seem to have added accidentally.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

http://hg.mozilla.org/qa/mozmill-automation/rev/42fceb6111e6

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I had to push a bustage fix:
http://hg.mozilla.org/qa/mozmill-automation/rev/416592141962