Last Comment Bug 784889 - Use nullptr in a function that returns a pointer
: Use nullptr in a function that returns a pointer
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-22 18:13 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2012-08-23 19:21 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
use nullptr (371 bytes, patch)
2012-08-22 18:13 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Ms2ger: review+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2012-08-22 18:13:33 PDT
Created attachment 654475 [details] [diff] [review]
use nullptr
Comment 1 Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-08-22 23:46:48 PDT
Comment on attachment 654475 [details] [diff] [review]
use nullptr

Will this give the right error handling behavior?
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-08-23 01:04:17 PDT
Comment on attachment 654475 [details] [diff] [review]
use nullptr

Review of attachment 654475 [details] [diff] [review]:
-----------------------------------------------------------------

We might need to set an exception, but it doesn't look like this code tends to be reached.

In any case, this change is correct.
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-08-23 19:21:03 PDT
https://hg.mozilla.org/mozilla-central/rev/2995a63cf399

Note You need to log in before you can comment on or make changes to this bug.