Closed Bug 784889 Opened 7 years ago Closed 7 years ago

Use nullptr in a function that returns a pointer

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file)

Attached patch use nullptrSplinter Review
No description provided.
Attachment #654475 - Flags: review?(jonas)
Comment on attachment 654475 [details] [diff] [review]
use nullptr

Will this give the right error handling behavior?
Attachment #654475 - Flags: review?(jonas) → review?(bent.mozilla)
Comment on attachment 654475 [details] [diff] [review]
use nullptr

Review of attachment 654475 [details] [diff] [review]:
-----------------------------------------------------------------

We might need to set an exception, but it doesn't look like this code tends to be reached.

In any case, this change is correct.
Attachment #654475 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/2995a63cf399
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.