784929 - Leak in url.js (with add-on Copy Tiny Url 1.0)

Status: RESOLVED INVALID

(Add-on SDK Graveyard :: General, defect)

Description

[Thomasy]

Attachment: copytinyurl.xpi

User Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120822030558

Steps to reproduce:

Firefox 14.0.1 Lubuntu 12.04
Firefox Nightly 17.0a1 (2012-08-22) Lubuntu 12.04

If you install the Copy Tiny Url add-on in version 1.0 (see attachment), there are many compartments System Principal even after disabling the add-on.( More compartments in Nightly than release version)

Steps to reproduce:
1. Create a new profile.
2. Install the add-on.
3. Open the add-on manager, disable the add-on.
4. Open about:memory?verbose and close all other tabs.
5. Click 'Minimize memory usage'.



Actual results:


Open 'about:compartments'.
Still many compartments like this:
 compartment([System Principal], resource://jid1-epxk6cb8p5cx9w-at-jetpack/api-utils/lib/url.js)

Add-on SDK version is 1.9

compartments in Firefox 14.0.1

Main Process

User Compartments
http://localhost/extensions-dummy/discoveryURL

System Compartments
[System Principal]
[System Principal], jar:file:///tmp/tmp7bPyrA.mozrunner/extensions/[e-mail]!/bootstrap.js
[System Principal], resource://jid1-epxk6cb8p5cx9w-at-jetpack/api-utils/lib/url.js
atoms
moz-nullprincipal:{b6df2f6f-542a-4633-ad07-834b8c8a047a}

Ghost Windows



Expected results:

No jetpack compartments

Comment 1

[Thomasy]

Attachment: Compartments in Nightly 17.0a1 (2012-08-22) Lubuntu 12.04

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

This appears to be an issue with your add-on, you use the `window-utils` module to track/untrack windows, and the onTrack method is adding a 'DOMContentLoaded' event listener to all documents, but the onUntrack method only cleans documents with getAttribute("windowtype") == "navigator:browser".  SO I'm pretty certain that is the cause of the leak.